New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872355 link

Starred by 1 user
Status: Duplicate
Merged: issue 872381
Owner: ----
Closed: Aug 13
Cc:
davidben@chromium.org
qyears...@chromium.org
█ diegomtzg@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Blacklisting file from SpellChecker

Project Member Reported by svaldez@chromium.org, Aug 8 
Run ID: 5739360200687616

Is it possible to blacklist a file from being run against SpellChecker? Due to how third_party/boringssl/crypto_test_data.cc is generated, linebreaks end up causing SpellChecker to report a number of words as misspelled.

Comment 1 by svaldez@chromium.org, Aug 8

Cc: davidben@chromium.org

Comment 2 by diegomtzg@google.com, Aug 8

Cc: qyearsley@google.com
The spellchecker should only check words in comments anyway (unless the file extension is not recognized). We fixed an issue yesterday with C++ file extensions but I don't believe that it's live yet. 

In any case, you bring up a good point, maybe the spellchecker shouldn't run on third party libraries. Could you share a link to the CL where this happened?

Comment 3 by svaldez@chromium.org, Aug 8 

This happened on:

https://chromium-review.googlesource.com/c/chromium/src/+/1167469

in the crypto_test_data.cc file.

Comment 4 by qyears...@chromium.org, Aug 8

Cc: -qyearsley@google.com qyears...@chromium.org
We don't necessarily want to block tricium from running on anything in third_party, because there's third_party/blink and README files in third_party. I suspect blacklisting individual files isn't very scalable.

Perhaps we just don't want to run on DEPS rolls like that change? Filed bug 872381 for that.

Comment 5 by s...@google.com, Aug 9

Status: Available (was: Untriaged)

Comment 6 by qyears...@chromium.org, Aug 13

Mergedinto: 872381
Status: Duplicate (was: Available)
►

Sign in to add a comment