WebContentsAudioInputStreamTest.MirroringNothingWithTargetChange/1 is flakey |
||||
Issue descriptionIn https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/782 this flaked, and try-flakes shows it flaking in try runs on Fuchsia/x64 (e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/79651), with: [ RUN ] WebContentsAudioInputStreamTest.MirroringNothingWithTargetChange/1 ../../content/browser/media/capture/web_contents_audio_input_stream_unittest.cc:352: Failure Mock function called more times than expected - returning directly. Function call: StartMirroring(0x86a444818820) Expected: to be called once Actual: called twice - over-saturated and active Stack trace: #00: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:? #01: testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > const&) at gmock-internal-utils.cc:? #02: testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith(void*) at gmock-spec-builders.cc:? #03: content::(anonymous namespace)::MockAudioMirroringManager::StartMirroring(content::AudioMirroringManager::MirroringDestination*) at web_contents_audio_input_stream_unittest.cc:? ../../content/browser/media/capture/web_contents_audio_input_stream_unittest.cc:243: Failure Actual function call count doesn't match EXPECT_CALL(*mock_mirroring_manager_, StartMirroring(NotNull()))... Expected: to be called once Actual: never called - unsatisfied and active Stack trace: #00: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:? #01: testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> > const&) at gmock-internal-utils.cc:? #02: testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() at gmock-spec-builders.cc:? #03: content::(anonymous namespace)::MockAudioMirroringManager::~MockAudioMirroringManager() at web_contents_audio_input_stream_unittest.cc:? #04: content::(anonymous namespace)::MockAudioMirroringManager::~MockAudioMirroringManager() at web_contents_audio_input_stream_unittest.cc:? #05: content::WebContentsAudioInputStreamTest::~WebContentsAudioInputStreamTest() at web_contents_audio_input_stream_unittest.cc:? #06: content::WebContentsAudioInputStreamTest_MirroringNothing_Test::~WebContentsAudioInputStreamTest_MirroringNothing_Test() at web_contents_audio_input_stream_unittest.cc:? [ FAILED ] WebContentsAudioInputStreamTest.MirroringNothingWithTargetChange/1, where GetParam() = true (155 ms) This suggests some timing-dependency in the test, causing it to flake under Fuchsia, which has different scheduling properties to desktop platform schedulers at present, and for which bots run under nested virtualization. Assigning to self to disable the test to avoid the immediate issue of try flakes.
,
Aug 8
CL to disable the test is in-flight; assigning to miu@ to triage.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195815d7a2891b9bde2b1fa12d5242e00f15816f commit 195815d7a2891b9bde2b1fa12d5242e00f15816f Author: Wez <wez@chromium.org> Date: Wed Aug 08 17:34:25 2018 Disable WebContentsAudioInputStreamTest.MirroringNothingWithTargetChange This test appears to have timing/scheduling-dependent flakes. TBR=miu Bug: 872340 Change-Id: I92a42315b4b5e15bfae88f5b7430b4e0210a3ea7 Reviewed-on: https://chromium-review.googlesource.com/1167560 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581618} [modify] https://crrev.com/195815d7a2891b9bde2b1fa12d5242e00f15816f/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc
,
Aug 8
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16bde789cde9618a73e8b4d8de3bfb07dcb4ed66 commit 16bde789cde9618a73e8b4d8de3bfb07dcb4ed66 Author: Xida Chen <xidachen@chromium.org> Date: Wed Aug 15 18:01:44 2018 Correctly disable MirroringNothingWithTargetChange The current code has a type, it should be DISABLED_xxx TBR=wjmaclean@chromium.org NOTRY=true Bug: 872340 Change-Id: I910b6913eace9b4710a7aac990d783f0f842beee Reviewed-on: https://chromium-review.googlesource.com/1176176 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583321} [modify] https://crrev.com/16bde789cde9618a73e8b4d8de3bfb07dcb4ed66/content/browser/media/capture/web_contents_audio_input_stream_unittest.cc
,
Sep 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by w...@chromium.org
, Aug 8