Issue 872339 link

Starred by 5 users

Issue metadata

Status:	Untriaged
Owner:	----
Cc:	msi...@igalia.com nickdi...@igalia.com
Components:	UI
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Mac
Pri:	3
Type:	Task
Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired

Blocked on: View detail
issue 875161
issue 891175
issue 891613
issue 891654

Implement PlatformScreen for all ozone platforms

Project Member Reported by sergeyu@chromium.org, Aug 8

Issue description

https://crrev.com/c/1162354 added PlatformScreen interface in Ozone. Currently this interface is implemented only for Scenic (after https://crrev.com/c/1162426 lands). It needs to be implemented for all platforms and then OzonePlatform::CreateScreen() callers won't need to handle nullptr result.

Comment 1 by msi...@igalia.com, Aug 16

Cc: msi...@igalia.com

Is this now a way to produce a list of displays in ozone? I ask because we have already had a DesktopScreenOzone, which implemented ScreenBase and is used by Wayland, for example.

We will take care about Wayland then.

Comment 2 by sergeyu@chromium.org, Aug 16

Yes, I think we will want to implement PlatformScreen for Wayland. AFAICT DesktopScreenOzone doesn't implement all Screen functionality. E.g. GetDisplayNearestWindow() always returns "primary" display. That function is rather hard to implement correctly on layers above ozone.
Note that PlatformScreen is not actually used in most cases ATM. You will want to update the code that initializes screen to create ScreenOzone instead of DesktopScreenOzone (and then DesktopScreenOzone can be removed completely).