New issue
Advanced search Search tips

Issue 872336 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Notifications from ServiceWorker are not clickable - glitch.com example

Reported by marius.g...@gmail.com, Aug 8

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

Steps to reproduce the problem:
Simple Test Case available here: https://nifty-tarsier.glitch.me/

What is the expected behavior?
All notifications should be clickable

What went wrong?
Only the first notification is clickable. We don't know why!

It's working in Firefox.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 68.0.3440.84  Channel: stable
OS Version: OS X 10.13.6
Flash Version:
 
Components: Blink>PushAPI
Labels: Needs-Feedback
I tried https://nifty-tarsier.glitch.me/ on 70.0.3510.0 on Linux and it seems working well.
Can you try it on Canary? https://www.google.com/chrome/canary
Labels: Needs-Triage-M68
We were able to rewrite the Test Case, which now can be reproduced in the first try most of the time. URL is the same. The notifications don't open any webpages, checking if the notification closes on click is enough.

I just reproduced it in Canaray, as well.

To reproduce, just click the "Send Notifications" button and you will receive 20 notifications. At least one of them is unclickable. Try again if it doesn't work at the first try.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 10

Cc: shimazu@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I made a short clip here: https://media.giphy.com/media/42GUGl29ao27rteFY8/giphy.mp4
I keep clicking on the "0" notification but it doesn't close.
I think I traced the problem down to the 'requireInteraction' parameter at the 'registration.showNotification' method.
Notifications only seem to become unclickable when requireInteraction is true.

I made a much simpler and very minimalistic demo to demonstrate this:
https://mammoth-flood.glitch.me/

Cc: swarnasree.mukkala@chromium.org
Labels: Needs-Feedback Triaged-ET
Unable to reproduce the issue on reported chrome version #68.0.3440.84 and on latest chrome  version #70.0.3521.0 using Mac OS 10.13.6 and on Ubuntu 17.10 by following below steps.

Steps:
=====
1.Launched chrome.
2.Opened the link https://mammoth-flood.glitch.me/ and clicked on 'Send notifications' button.
3.Observed multiple notifications and able to close all invoked notifications.
Note: Clicked the 'send notifications' button multiple times(~10)

Attached the screencast reference.

@Reporter: Could you please review the attached screen-cast and confirm if anything being missed here and request you to retry this issue with fresh profile without any extensions/apps or reset all the flags and let us know if issue still persists.
872336.mp4
2.8 MB View Download
Thank you so much for observing this, swarnasree.mukkala@chromium.org :-)

I think you misunderstood the problem a bit. The notifications should close when clicking on their body. Instead, the 'onnotificationclick' event is not even being triggered sometimes and some of the notifications do not close.

I made a screencast (happened at first try).
Screencast Chrome Bug Notifications.mp4
6.1 MB View Download
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 15

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: peter@chromium.org
Status: Assigned (was: Unconfirmed)
Looks like this is a mac specific issue (I can't repro on my Linux machine).

peter@: Can you triage this?
The bug happened to me on Mac and Windows. I don't have a Linux machine to test.

Do you have any ETA how long it could take until this will be fixed? This has very high severity for us right now.
Yeah, there's a bunch of database read errors when processing notification clicks, though it doesn't have major severity across the board. We definitely shouldn't be keeping those around, so I'll land a bunch of CLs to close them.

It would be good to understand why we end up in this situation in the first place, and why it seems to be more severe in your case, but your test case is rather huge. Is there any way you could reduce its size further, Marius?
Hi Peter,

did you check out https://mammoth-flood.glitch.me/ ? It's a different and very minimalistic example than in the first post.

There is nothing related to IndexedDB in this example.
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9489f286c1f5619882d86c0d4c6cef2cb781409f

commit 9489f286c1f5619882d86c0d4c6cef2cb781409f
Author: Peter Beverloo <peter@chromium.org>
Date: Wed Aug 22 16:20:01 2018

Close activated notifications if the developer can't handle them

There is a low rate of errors where notification clicks cannot be
processed due to internal reasons, such as not being able to find it in
the appropriate database or database read errors. In those cases we
can't give the developer the means to handle the event, and the
notification sticks around until the user closes it.

Per this CL, we'll automatically close notifications when the click
could not be processed. The eventual goal is for such clicks to be very
rare, so fixes will happen in other parts of the code as well.

Bug: 872336
Change-Id: I3f184b6d1a36deb42d9f5c95be5dc15aa285bb66
Reviewed-on: https://chromium-review.googlesource.com/1183674
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585033}
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/chrome/browser/notifications/persistent_notification_handler_unittest.cc
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/content/public/browser/notification_event_dispatcher.h
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/content/public/common/persistent_notification_status.h
[modify] https://crrev.com/9489f286c1f5619882d86c0d4c6cef2cb781409f/tools/metrics/histograms/enums.xml

Unfortunately the same bug happened to me in Windows 10 on the latest Canary (I assume Peters patch was already included). See the attached video.

The example I was using here uses the most minimalistic ServiceWorker file possible:
https://gifted-town.glitch.me/

CRBug Windows 10.mov
7.4 MB View Download
I came here to raise the same bug I'm experiencing on Windows 10 Chrome 68.0.3440.106 Since 5 days ago when we first built our own push feature.
However we never experienced the bug on OSX Chrome (also version 68.0.3440.106).

I just wanted to add that in our case we are using a notification action (a button in the notification to go to the link), and clicking this button also does not trigger the 'notificationclicked' event in our service worker.

The use of 'requireInteraction' flag had no effect on this bug for us.
Just to clarify. This bug has changed from the original definition.

A clicked notification never hits the 'notificationclick' event listener unless it is the most recent notification.

The bug now is exclusive to Chrome on Windows 68.0.3440.106

Easily reproducible in Marius's example here https://gifted-town.glitch.me/

Should we raise a new bug?
Status: Untriaged (was: Assigned)
I'll reset it to Untriaged for now since the bug changed. Peter can you take a look again?
Cc: phanindra.mandapaka@chromium.org
 Issue 882172  has been merged into this issue.
(blink worker triage)

peter@: any update on this?
Components: -Blink>ServiceWorker
Labels: -OS-Mac OS-Windows
Removing from SW triage queue. Adding Windows and removing Mac per comments 15, 16, and  17.
Any update on this? It seems windows is getting bader and bader by every Chrome release. I think this has pretty high priority.
Notifications which are not clicked and then pushed to the notification center can't be clicked anymore, not even one.
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment