New issue
Advanced search Search tips

Issue 872333 link

Starred by 1 user
Status: Assigned
Owner:
chaopeng@chromium.org
Cc:
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Touchpad scrolling stop on infinite scrolling page

Project Member Reported by chaopeng@chromium.org, Aug 8 
Chrome Version: M68
OS: Win10

What steps will reproduce the problem?
(0) on precision touchpad laptop
(1) open https://infinite-scroll.com/demo/full-page/
(2) keep scrolling 

You will see scroll stop when page loading new content. And you can not scroll until finger leave touchpad and tap again.

Comment 1 by chaopeng@chromium.org, Aug 8

Status: Assigned (was: Untriaged)
This issue is causing by we call DirectManipulationHelper::Deactivate when new content loaded (resize). And DirectManipulationHelper::Deactivate calls viewport stop since DirectManipulation will stop working if we call IDirectManipulationManager::Deactivate while user scrolling.

I double check the document for IDirectManipulationManager::Deactivate:

> Deactivates Direct Manipulation for processing input and handling callbacks on the specified window.

We should never call this method.

The proper fix should be remove DirectManipulationHelper::Deactivate and DirectManipulationHelper::Activate. Only Activate DirectManipulation when initialization.

Comment 2 by chaopeng@chromium.org, Aug 8

Summary: Touchpad scrolling stop on infinite scrolling page (was: Touchpad scrolling stop on infinity scrolling page.)
Tried remove DirectManipulationHelper::Deactivate and DirectManipulationHelper::Activate calls, it would make DirectManipulation totally stop working. It seems Windows expects application call them when window visibility change.

Maybe we should not call window show/hide when content resize.

content::LegacyRenderWidgetHostHWND::Show [0x59121D2A+40]
content::RenderWidgetHostViewAura::UpdateLegacyWin [0x591BD161+229]
content::RenderWidgetHostViewAura::InternalSetBounds [0x591BC921+131]
content::RenderWidgetHostViewAura::SetSize [0x591BC886+120]
content::WebContentsViewAura::SizeContents [0x592F44E6+66]
content::WebContentsImpl::UpdateRenderViewSizeForRenderManager [0x592EA96F+63]
►

Sign in to add a comment