chrome_cleaner_unittests broken |
||
Issue descriptionYour change https://chromium-review.googlesource.com/c/chromium/src/+/1163635 broke two bots. Win7 Tests (dbg)(1) and Win10 Tests x64 (dbg): [ FATAL ] ../../third_party/googletest/src/googletest/include\gtest/internal/gtest-param-util.h(568):: Condition IsValidParamName(param_name) failed. Parameterized test name '4-byte_object_<01-00_00-00>' is invalid, in ../../chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc line 1435 No, I don't understand why, but it's the only chrome_cleaner change in the runs where the failures started across two bots. I tried to revert but it doesn't revert cleanly.
,
Aug 8
Holding off for two seconds since Joe says he has a fix.
,
Aug 8
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f39be8d2aaa1090861b775a5b7f303b1cd847635 commit f39be8d2aaa1090861b775a5b7f303b1cd847635 Author: Joe Mason <joenotcharles@chromium.org> Date: Wed Aug 08 17:01:42 2018 Stop using GetParamNameForTest with ExecutionMode This is a workaround for assertion failures in debug builds. GetParamNameForTest uses operator<< to format test params, and the wrong override is being chosen for ExecutionMode parameters. TBR=proberge Bug: 872324 Change-Id: Ifc6a561835f61454af54960829a9ceb8303e16f2 Reviewed-on: https://chromium-review.googlesource.com/1167552 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#581604} [modify] https://crrev.com/f39be8d2aaa1090861b775a5b7f303b1cd847635/chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc [modify] https://crrev.com/f39be8d2aaa1090861b775a5b7f303b1cd847635/chrome/chrome_cleaner/settings/cleaner_settings_unittest.cc
,
Aug 8
|
||
►
Sign in to add a comment |
||
Comment 1 by a...@chromium.org
, Aug 8