Bottom toolbar does not disappear in fullscreen |
||
Issue descriptionSo far this only happens in one specific instance: 1) Go to https://eeyo.io/bonnie2 2) Tap scary bunny 3) Press enter (or enter anything) 4) Type "fullscreen" 5) Hide keyboard After these steps, the Android bottom toolbar remains visible while the top is hidden. I suspect the composited version is hidden because it is tied to the top controls, meaning the bottom toolbar Android view is missing some signal to hide itself.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2abccfabab215294ce631fc20d09708089c810ae commit 2abccfabab215294ce631fc20d09708089c810ae Author: Matthew Jones <mdjones@chromium.org> Date: Thu Aug 09 21:36:12 2018 Fix bottom toolbar showing while in fullscreen This patch fixes an issue with the bottom toolbar when entering fullscreen while the keyboard is visible. To conserve space while the keyboard is showing, the bottom controls height is set to 0 and reset when the keyboard is hidden. This does not account for fullscreen mode, so when the keyboard is hidden it blindly tells the controls to become visible again. This patch adds logic to update the bottom toolbar when the controls height is restored and only conditionally shows the toolbar if another browser feature isn't blocking it. Bug: 872323 Change-Id: Ic3f33fcd7ae207415a5d36b56dba86ec216d3a51 Reviewed-on: https://chromium-review.googlesource.com/1167997 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581903} [modify] https://crrev.com/2abccfabab215294ce631fc20d09708089c810ae/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
,
Aug 9
|
||
►
Sign in to add a comment |
||
Comment 1 by mdjones@chromium.org
, Aug 8