New issue
Advanced search Search tips

Issue 872311 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Aug 8
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Beta cannot build

Project Member Reported by gambard@chromium.org, Aug 8 
Beta cannot build because of OmniboxViewController.
../../ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm:37:13: error: property implementation must have its declaration in interface 'OmniboxViewController' or one of its extensions
@synthesize dispatcher = _dispatcher;
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93c3352ba10b3f25e2ddb88cd17373cafc31105

commit d93c3352ba10b3f25e2ddb88cd17373cafc31105
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Aug 08 15:03:53 2018

Fix compilation issues on Omnibox

The @synthesize was added as a merge conflict was incorrectly resolved.

Bug:  872311 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iff040543b9540f51b96cadfb51ae3633d86a2690
Reviewed-on: https://chromium-review.googlesource.com/1166966
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#494}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d93c3352ba10b3f25e2ddb88cd17373cafc31105/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

Comment 2 by gambard@chromium.org, Aug 8

Status: Fixed (was: Assigned)
►

Sign in to add a comment