New issue
Advanced search Search tips

Issue 872305 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task



Sign in to add a comment

Crawler and installer tests

Project Member Reported by rouslan@chromium.org, Aug 8

Issue description

Need crawler and installer tests for payment handler JIT.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a1a4b02fd1c7d7c623513274c24692d6602d8d

commit 33a1a4b02fd1c7d7c623513274c24692d6602d8d
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Aug 09 14:32:02 2018

Add tests for JIT installable payment handlers.

Bug: 872305
Change-Id: I992e534ab0ca48affc14464c23af41a495209c58
Reviewed-on: https://chromium-review.googlesource.com/1168084
Reviewed-by: Ganggui Tang <gogerald@chromium.org>

[modify] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
[modify] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/payments/core/test_payment_manifest_downloader.cc
[modify] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/payments/core/test_payment_manifest_downloader.h
[add] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/test/data/payments/kylepay.com/app.js
[add] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/test/data/payments/kylepay.com/app.json
[add] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/test/data/payments/kylepay.com/payment-manifest.json
[add] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/test/data/payments/kylepay.com/webpay
[add] https://crrev.com/33a1a4b02fd1c7d7c623513274c24692d6602d8d/components/test/data/payments/kylepay.com/webpay.mock-http-headers

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14e50634d63c8b493f932cca5d3079e02f54f05f

commit 14e50634d63c8b493f932cca5d3079e02f54f05f
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 09 19:17:43 2018

Revert "Add tests for JIT installable payment handlers."

This reverts commit 33a1a4b02fd1c7d7c623513274c24692d6602d8d.

Reason for revert: Due to Gerrit outage  http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.

Original change's description:
> Add tests for JIT installable payment handlers.
> 
> Bug: 872305
> Change-Id: I992e534ab0ca48affc14464c23af41a495209c58
> Reviewed-on: https://chromium-review.googlesource.com/1168084
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>

TBR=rouslan@chromium.org,gogerald@chromium.org

Change-Id: I7acd908143a9ca613aec1a3270bd4cb906af45c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872305
Reviewed-on: https://chromium-review.googlesource.com/1169849
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/14e50634d63c8b493f932cca5d3079e02f54f05f/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
[modify] https://crrev.com/14e50634d63c8b493f932cca5d3079e02f54f05f/components/payments/core/test_payment_manifest_downloader.cc
[modify] https://crrev.com/14e50634d63c8b493f932cca5d3079e02f54f05f/components/payments/core/test_payment_manifest_downloader.h
[delete] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/components/test/data/payments/kylepay.com/app.js
[delete] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/components/test/data/payments/kylepay.com/app.json
[delete] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/components/test/data/payments/kylepay.com/payment-manifest.json
[delete] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/components/test/data/payments/kylepay.com/webpay
[delete] https://crrev.com/bad2ad666be598479b7b9fe8449416f37d2444b5/components/test/data/payments/kylepay.com/webpay.mock-http-headers

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d0571258312bf9dd56c90f1e36879c852fd9d95

commit 8d0571258312bf9dd56c90f1e36879c852fd9d95
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Aug 13 15:57:48 2018

Reland "Add tests for JIT installable payment handlers."

This is a reland of 33a1a4b02fd1c7d7c623513274c24692d6602d8d

Original change's description:
> Add tests for JIT installable payment handlers.
>
> Bug: 872305
> Change-Id: I992e534ab0ca48affc14464c23af41a495209c58
> Reviewed-on: https://chromium-review.googlesource.com/1168084
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>

TBR=gogerald@chromium.org

Bug: 872305
Change-Id: Icdf80a7bb92b53b85c09648bf483f1671fcfa662
Reviewed-on: https://chromium-review.googlesource.com/1172542
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582597}
[modify] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
[modify] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/payments/core/test_payment_manifest_downloader.cc
[modify] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/payments/core/test_payment_manifest_downloader.h
[add] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/test/data/payments/kylepay.com/app.js
[add] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/test/data/payments/kylepay.com/app.json
[add] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/test/data/payments/kylepay.com/payment-manifest.json
[add] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/test/data/payments/kylepay.com/webpay
[add] https://crrev.com/8d0571258312bf9dd56c90f1e36879c852fd9d95/components/test/data/payments/kylepay.com/webpay.mock-http-headers

Sign in to add a comment