New issue
Advanced search Search tips

Issue 872290 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

"Settings" link not tappable on UnifiedConsent

Project Member Reported by gambard@chromium.org, Aug 8

Issue description

On iPhone non-plus only.
Turn the language setting to french.

What steps will reproduce the problem?
(1) Open Unified Consent
(2) Tap on the "Parametres" link

What is the expected result?
The link should be tappable.

What happens instead?
The link is below the white gradient, preventing it from being tapped.
 
Actually, this is because the "settings" link isn't properly positioned.
The "settings" link isn't correctly positioned because the "Google Translate" is using a no-break whitespace. So the UILabel is correctly displaying it on one line, the util used to get its position isn't taking it into account and is counting it as displayed on two line, creating a discrepancy.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b217ee7efcf09233819d5480d93c8c0085b9059

commit 5b217ee7efcf09233819d5480d93c8c0085b9059
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 10 09:13:56 2018

[iOS] Make LabelLink working with unbreakable spaces

When the LabelLink is displaying a text containing an unbreakable space,
the unbreakable space is preventing two words from being broken at the
end of a line. However, the ManualTextFramer used to get the position of
the link isn't respecting the unbreakable spaces.
So the displayed text isn't breaking the words at the end of the line
but the link is positioned as if the words were broken. So the position
of the link is wrong.

Bug:  872290 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9b2bae32a47e19b14c397e230aade87b3cb88157
Reviewed-on: https://chromium-review.googlesource.com/1169014
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582098}
[modify] https://crrev.com/5b217ee7efcf09233819d5480d93c8c0085b9059/ios/chrome/browser/ui/util/manual_text_framer.mm
[modify] https://crrev.com/5b217ee7efcf09233819d5480d93c8c0085b9059/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment