The UnifiedConsent and ConsentBump UI should be accessible.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e5d424276a3729c5e5f5950932f235d38155ae commit f2e5d424276a3729c5e5f5950932f235d38155ae Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 09 09:29:33 2018 [iOS] Add accessibility for UnifiedConsent This CL adds accessibility (larger fonts and VoiceOver) to the Unified Consent and the Consent Bump. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie6699132fe395b34717a8097d66ee97bf9406e13 Reviewed-on: https://chromium-review.googlesource.com/1167504 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#581842} [modify] https://crrev.com/f2e5d424276a3729c5e5f5950932f235d38155ae/ios/chrome/browser/ui/authentication/authentication_constants.h [modify] https://crrev.com/f2e5d424276a3729c5e5f5950932f235d38155ae/ios/chrome/browser/ui/authentication/authentication_constants.mm [modify] https://crrev.com/f2e5d424276a3729c5e5f5950932f235d38155ae/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.mm [modify] https://crrev.com/f2e5d424276a3729c5e5f5950932f235d38155ae/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_header_item.mm [modify] https://crrev.com/f2e5d424276a3729c5e5f5950932f235d38155ae/ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.mm [modify] https://crrev.com/f2e5d424276a3729c5e5f5950932f235d38155ae/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b73143abfac967ceddc0fc631212d72e48ceb881 commit b73143abfac967ceddc0fc631212d72e48ceb881 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Aug 13 15:30:35 2018 [iOS] Add support for the escape gesture This CL adds a way to dismiss the IdentityChooser popup using the escape gesture. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia0b64c28787ed651596e936aa806ed42b94e50db Reviewed-on: https://chromium-review.googlesource.com/1172431 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582584} [modify] https://crrev.com/b73143abfac967ceddc0fc631212d72e48ceb881/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b2ab78928315ecdec95962e6f138bffcdecd868 commit 5b2ab78928315ecdec95962e6f138bffcdecd868 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Aug 13 15:37:12 2018 [iOS] Add accessibility for IdentityPicker This CL adds dynamic for the IdentityPicker, making sure that the name and email can spread on multiple lines and respond nicely when the font is increased. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea05b977c7a6f6fe199c0e8d4e6325ac05936ef0 Reviewed-on: https://chromium-review.googlesource.com/1172423 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582588} [modify] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/ios/chrome/browser/ui/authentication/authentication_constants.mm [modify] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_header_item.mm [modify] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_mediator.mm [modify] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.mm [modify] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_view.mm [modify] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/558c772de44e3808d6be8d6e2f1a995dff883e50 commit 558c772de44e3808d6be8d6e2f1a995dff883e50 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 16 08:38:08 2018 Add consumer protocol for the IdentityChooser This CL adds a consumer protocol, implemented by the IdentityChooserViewController. It allows the mediator to use it in a more abstract way. This CL also changes the structure of the TableView to have only one section instead of two. It allows the header to be self sized as the self sizing headers don't work with 0-height header. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I961ffb9962794b518d4630972a1b3d9d8c7d8764 Reviewed-on: https://chromium-review.googlesource.com/1174543 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#583582} [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/BUILD.gn [add] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_consumer.h [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_coordinator.mm [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_header_item.mm [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_mediator.h [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_mediator.mm [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.h [modify] https://crrev.com/558c772de44e3808d6be8d6e2f1a995dff883e50/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_view_controller.mm
Comment 1 by bugdroid1@chromium.org
, Aug 9