New issue
Advanced search Search tips

Issue 872267 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----
Team-Accessibility



Sign in to add a comment

SpokenFeedbackTest hanging on chromium.chromiumos/linux-chromeos-dbg

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 8

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of futhark@google.com

interactive_ui_tests failing on chromium.chromiumos/linux-chromeos-dbg

Builders failed on: 
- linux-chromeos-dbg: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg


 
Tests are currently timing out waiting for EnableChromeVox() to return:


#10 0x000005312dce Still waiting for the following processes to finish:
	out/CROS/interactive_ui_tests --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 --single_process --test-launcher-output=/tmp/.org.chromium.Chromium.0bIt4t/resultsMTyC4F/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.0bIt4t/d8X1u4C
content::RunThisRunLoop()
#11 0x000005314a18 content::MessageLoopRunner::Run()
#12 0x000004321333 chromeos::SpeechMonitor::SkipChromeVoxMessage()
#13 0x000004321268 chromeos::SpeechMonitor::SkipChromeVoxEnabledMessage()
#14 0x000000ae1ef0 chromeos::LoggedInSpokenFeedbackTest::EnableChromeVox()
#15 0x000000add96b chromeos::SpokenFeedbackTest_OverviewMode_Test::RunTestOnMainThread()

Owner: jamescook@chromium.org
Status: Assigned (was: Available)
Not able to find the culprit, so ifdefed out all the tests:

https://chromium-review.googlesource.com/c/chromium/src/+/1167294

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a382e8dfd749815f638541dddc5cf9c54cbc50b2

commit a382e8dfd749815f638541dddc5cf9c54cbc50b2
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Aug 08 14:51:47 2018

All SpokenFeedback tests hand in ChromeOS dbg.

TBR=jamescook@chromium.org

Bug:  872267 
Change-Id: I8ff0cf1d3615bb73c04b5342a96c24f0c914fe75
Reviewed-on: https://chromium-review.googlesource.com/1167294
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581559}
[modify] https://crrev.com/a382e8dfd749815f638541dddc5cf9c54cbc50b2/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Cc: jamescook@chromium.org
Components: UI>Accessibility>ChromeVox
Labels: -Pri-2 OS-Chrome Pri-1
Owner: dtseng@chromium.org
Summary: SpokenFeedbackTest hanging on chromium.chromiumos/linux-chromeos-dbg (was: interactive_ui_tests failing on chromium.chromiumos/linux-chromeos-dbg)
dtseng, the sheriff just disabled all spoken feedback browser tests on chromeos debug. I think this might be related to your ChromeVox CL that got reverted. Maybe they can be put back now.

https://chromium-review.googlesource.com/c/chromium/src/+/1165787

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5cb3aa268e675987e891fbffc2ec008b103420f

commit f5cb3aa268e675987e891fbffc2ec008b103420f
Author: David Tseng <dtseng@chromium.org>
Date: Wed Aug 08 16:53:57 2018

Revert "All SpokenFeedback tests hand in ChromeOS dbg."

This reverts commit a382e8dfd749815f638541dddc5cf9c54cbc50b2.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> All SpokenFeedback tests hand in ChromeOS dbg.
> 
> TBR=jamescook@chromium.org
> 
> Bug:  872267 
> Change-Id: I8ff0cf1d3615bb73c04b5342a96c24f0c914fe75
> Reviewed-on: https://chromium-review.googlesource.com/1167294
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581559}

TBR=avi@chromium.org,jamescook@chromium.org,dtseng@chromium.org,futhark@chromium.org

Change-Id: Ie0834cb7f690ec20acc426ea05504d478e46604f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  872267 
Reviewed-on: https://chromium-review.googlesource.com/1167623
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581600}
[modify] https://crrev.com/f5cb3aa268e675987e891fbffc2ec008b103420f/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Status: fixed (was: Assigned)
chromeos-dbg green for chromevox. clsoing.

Sign in to add a comment