New issue
Advanced search Search tips

Issue 872258 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

chromevox_tests failing on chromium.chromiumos/linux-chromeos-dbg

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 8

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of futhark@google.com

chromevox_tests failing on chromium.chromiumos/linux-chromeos-dbg

Builders failed on: 
- linux-chromeos-dbg: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg


 
Owner: dtseng@chromium.org
Status: Assigned (was: Available)
Disabling test here:

https://chromium-review.googlesource.com/c/chromium/src/+/1167057
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e41039e1dadc49e0846b0a2fdc3a15cb9f615bdd

commit e41039e1dadc49e0846b0a2fdc3a15cb9f615bdd
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Aug 08 13:22:12 2018

Disabled failing chromevox test.

BackgroundTest.NavigationEscapesEdit fails on linux-chromeos-dbg.

TBR=dtseng@chromium.org

Bug:  872258 
Change-Id: I4dc957a290bebb4cfa9d60c0a5240100de111240
Reviewed-on: https://chromium-review.googlesource.com/1167057
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581543}
[modify] https://crrev.com/e41039e1dadc49e0846b0a2fdc3a15cb9f615bdd/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb4a0c8057643c676637812f5f444ea0bd239dfc

commit bb4a0c8057643c676637812f5f444ea0bd239dfc
Author: David Tseng <dtseng@chromium.org>
Date: Wed Aug 08 16:52:34 2018

Revert "Disabled failing chromevox test."

This reverts commit e41039e1dadc49e0846b0a2fdc3a15cb9f615bdd.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disabled failing chromevox test.
> 
> BackgroundTest.NavigationEscapesEdit fails on linux-chromeos-dbg.
> 
> TBR=dtseng@chromium.org
> 
> Bug:  872258 
> Change-Id: I4dc957a290bebb4cfa9d60c0a5240100de111240
> Reviewed-on: https://chromium-review.googlesource.com/1167057
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581543}

TBR=avi@chromium.org,dtseng@chromium.org,futhark@chromium.org

Change-Id: Iac7ac28fd2734f166515922d28447b29a2d7b6cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  872258 
Reviewed-on: https://chromium-review.googlesource.com/1167602
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581599}
[modify] https://crrev.com/bb4a0c8057643c676637812f5f444ea0bd239dfc/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b

commit 5cddd557ba750e0751d9ea8bed5fcf4d16864e2b
Author: David Tseng <dtseng@chromium.org>
Date: Thu Aug 09 00:00:57 2018

Speculative fix for failing Chromevox tests on chromeos-dbg

NOTRY=true
TBR=avi@chromium.org

Bug:  872474 ,  872258 
Change-Id: I891cb4297476ab14d15878bcebafb109a5c3c60c
Reviewed-on: https://chromium-review.googlesource.com/1168472
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581725}
[modify] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.html

Cc: yoichio@chromium.org kojii@chromium.org
 Issue 872474  has been merged into this issue.
Waiting for the next build to cycle up and run. Didn't quite make the current build that's in progress.
Status: fixed (was: Assigned)

Sign in to add a comment