New issue
Advanced search Search tips

Issue 872252 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 705534
Owner: ----
Closed: Aug 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The WebSocket constructor shouldn't synchronously check for insecure ports

Project Member Reported by foolip@chromium.org, Aug 8

Issue description

Spec: https://html.spec.whatwg.org/multipage/web-sockets.html#dom-websocket

The "Establish a WebSocket connection" step is inside "in parallel", which means that it shouldn't run synchronously before the constructor algorithm returns. In the spec, port blocking happens in https://fetch.spec.whatwg.org/#port-blocking, which is within "Establish a WebSocket connection".

Recently updated tests are consistently failing because of this:
https://staging.wpt.fyi/results/websockets/Create-blocked-port.any.html?sha=eea0b54014&label=experimental

They are also failing in other browsers, so if this change doesn't seem good, please file an issue on https://github.com/whatwg/html/issues/new to change it.
 
https://github.com/whatwg/fetch/pull/738 is the spec change that led to the tests changing.
Mergedinto: 705534
Status: Duplicate (was: Untriaged)
annevk got here first, sorry.
dammit annevk

Sign in to add a comment