maps_pixel_test captures screenshot too early |
||
Issue descriptionIn maps_pixel_test new tiles are obtained from MessagePort. Before the recent scheduling change MessagePort events starved out the rest of the work by continuing to process events until we run out of them. This was fixed in crbug.com/867133 and message port events started to yield properly to other tasks, including compositing and requestAnimationFrames. Previously, the _SpinWaitOnRAF(3) hack was employed, which was brittle and stopped working now.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3495620c3ca9677f073295fa48fa2c40978ef2e commit e3495620c3ca9677f073295fa48fa2c40978ef2e Author: Alexander Timin <altimin@chromium.org> Date: Wed Aug 15 16:04:09 2018 Reland [blink] Add a time limit to message processing in MessagePort In addition to existing limit of 200 messages in a single task also limit it to 50 milliseconds to avoid starvation. This logic will be removed when message-per-task mojo dispatching will be implemented. This patch also modifies maps_pixel_test to use requestIdleCallback for detecting the end of the page load instead of three requestAnimationFrames. BUG=867133, 872239 R=mek@chromium.org,kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2de605bc6d069c23c3a991edcc0dccc995a4632 Reviewed-on: https://chromium-review.googlesource.com/1167053 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583267} [modify] https://crrev.com/e3495620c3ca9677f073295fa48fa2c40978ef2e/content/test/gpu/gpu_tests/maps_integration_test.py [modify] https://crrev.com/e3495620c3ca9677f073295fa48fa2c40978ef2e/third_party/blink/renderer/core/messaging/message_port.cc [modify] https://crrev.com/e3495620c3ca9677f073295fa48fa2c40978ef2e/third_party/blink/renderer/core/messaging/message_port.h
,
Aug 21
It looks like this issue was fixed in https://chromium-review.googlesource.com/1167053 so reassigning and closing. |
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, Aug 8Labels: -Pri-2 Needs-Feedback Pri-1