New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872238 link

Starred by 1 user
Status: Fixed
Owner:
yamaguchi@chromium.org
Closed: Oct 31
Cc:
tetsui@chromium.org
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Unified: close button appears for pinned notification

Project Member Reported by yamaguchi@chromium.org, Aug 8 
Chrome Version: 70.0.3517.0
Chrome OS Version: 109032.0.0
Network info: not relevant

(1) Create a pinned notification e.g. enable chrome://slow while chrome://flags/#enable-system-tray-unified enabled, then click "Enable performance data collection" button
(2) Close notification popup on the right bottom.
(3) Open notification center from the right bottom.
(4) Hover mouse cursor on the notification.

Expected Result:
No close button appears on the top right corner of the notification.

Actual Result:
A close button appears on the top right. When it's clicked, notification is not dismissed but the button disappears.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
always

What is the impact to the user, and is there a workaround? If so, what is
it?
No bad effect. It may make the UI look confusing.

Comment 1 by yamaguchi@chromium.org, Aug 8

Status: WontFix (was: Assigned)
Another step needed for repro.
(3.5) close notification center, then open it again.

MessageView::GetMode() is called 3 times by this step. |is_nested_| of the MessageView class instance is false for the first two calls.

Comment 2 by yamaguchi@chromium.org, Aug 8

Status: Assigned (was: WontFix)

Comment 3 by yamaguchi@chromium.org, Oct 25

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6fb62b11fe930c3d9de7c9611f9ff2ae77c7a08

commit f6fb62b11fe930c3d9de7c9611f9ff2ae77c7a08
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Oct 30 01:39:50 2018

Unified: Do not show close button on a pinned notification.

When a notification is PINNED type, the close button should only appear
when it's a popup, but not in the message center.
Messages in unified notification center are once created based on the
Notification and then marked as nested. The latter change affects
condition for show/hide close button. However the button visibility
was not updated reflecting it.

Bug:  872238 
Change-Id: Ie0718578153f47e35673b3566fb51933075488be
Reviewed-on: https://chromium-review.googlesource.com/c/1299095
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603726}
[modify] https://crrev.com/f6fb62b11fe930c3d9de7c9611f9ff2ae77c7a08/ui/message_center/views/message_view.cc

Comment 5 by yamaguchi@chromium.org, Oct 31

Status: Fixed (was: Started)
►

Sign in to add a comment