Regression: Unable to distinguish between grey backgroungd of thumbnail icon and grey highlight of mouse hover effect.
Reported by
dchau...@etouch.net,
Aug 8
|
|||||
Issue descriptionChrome Version: 70.0.3516.0 (Official Build) Revision a5cc86ce4806be7adb2876184069510bb6b95057-refs/branch-heads/3516@{#1} (32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04). Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Material Design Icons" flags from chrome://flags. What steps will reproduce the problem? 1. Launch Chrome and navigate to NTP. 2. Hover the mouse pointer on any thumbnail icon and observe. Actual: Unable to differentiate between grey background of thumbnail icon and grey highlight of mouse hover effect. Expected: Should be able to differentiate between grey background of thumbnail icon and grey highlight of mouse hover effect. This is a regression issue, broken in M-70 series, below is manual regression range: Bad build: 70.0.3514.0 (Revision: 580791) Good build: 70.0.3515.0 (Revision: 581084) Using the 'hasbisect-per-revision' script providing the bisect result: You are probably looking for a change made after 580948 (known good), but no later than 580949 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/631ac11aae294abc8b5a100a09e59af59aa6e229..c2111e0695751dcd6833f86930ea7905daef9494 Suspecting: https://chromium.googlesource.com/chromium/src/+/c2111e0695751dcd6833f86930ea7905daef9494 @kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the attached screen-cast for reference. Thank you.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df389241f95644081f57912138f9c11d384c4aea commit df389241f95644081f57912138f9c11d384c4aea Author: kristipark <kristipark@chromium.org> Date: Thu Aug 09 02:02:13 2018 [NTP] Fix z-index for MV tiles Relative is required for z-index to function. This will place the icon and title behind the semi-transparent background on hover. Screenshot: https://screenshot.googleplex.com/AK4t7nhOJfr.png Bug: 872206 , 864357 Change-Id: I2300cd6f5ef3a012ef7be2501f8cf27bc4d6f220 Reviewed-on: https://chromium-review.googlesource.com/1167648 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#581744} [modify] https://crrev.com/df389241f95644081f57912138f9c11d384c4aea/chrome/browser/resources/local_ntp/most_visited_single.css
,
Aug 10
Update: Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) machines using latest canary #70.0.3518.0 and issue is fixed. Hence adding TE-Verified labels. please refer below attached screen-cast for reference. Thank You.
,
Aug 10
Heads up that change 1167648 will be merged to M69 (merge approval given in http://crbug/864357).
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd62c506c4bc0a11a91446ccea70dfb2af8807a0 commit dd62c506c4bc0a11a91446ccea70dfb2af8807a0 Author: kristipark <kristipark@chromium.org> Date: Fri Aug 10 19:00:06 2018 [Merge M69] [NTP] Fix z-index for MV tiles and fix delete link on "enter" in the edit dialog [NTP] Fix z-index for MV tiles Relative is required for z-index to function. This will place the icon and title behind the semi-transparent background on hover. Screenshot: https://screenshot.googleplex.com/AK4t7nhOJfr.png Bug: 872206 , 864357 Change-Id: I2300cd6f5ef3a012ef7be2501f8cf27bc4d6f220 Reviewed-on: https://chromium-review.googlesource.com/1167648 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#581744} (cherry picked from commit df389241f95644081f57912138f9c11d384c4aea) [NTP] Fix delete link on "enter" in the edit dialog Pressing enter in the edit link dialog will no longer delete the link. The current event handler was not being called. (cherry picked from commit c49e1f764ac822e84bb29ea5e89fd16ffbd37579) Bug: 864357 Change-Id: Idbba0cf0a3f9f0afa7dbcf91b49ec45de5c9e144 Reviewed-on: https://chromium-review.googlesource.com/1169763 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#582020} Reviewed-on: https://chromium-review.googlesource.com/1171368 Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#541} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/dd62c506c4bc0a11a91446ccea70dfb2af8807a0/chrome/browser/resources/local_ntp/custom_links_edit.js [modify] https://crrev.com/dd62c506c4bc0a11a91446ccea70dfb2af8807a0/chrome/browser/resources/local_ntp/most_visited_single.css
,
Aug 16
Update: Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) machines using latest Beta #69.0.3497.42 and issue is fixed. Hence adding TE-Verified labels. please refer below attached screen-cast for reference. Thank You. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kristip...@chromium.org
, Aug 8