New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872203 link

Starred by 2 users
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Aug 27
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Windows 10 PWA: Check failed: height <= available_height (24 vs. 23)

Project Member Reported by alancutter@chromium.org, Aug 8 
Repro step: Maximise PWA window on Windows 10.

[10296:7244:0808/181025.059:FATAL:hosted_app_button_container.cc(282)] Check failed: height <= available_height (24 vs. 23)
Backtrace:
        base::debug::StackTrace::StackTrace [0x00007FF9644D81D4+36] (D:\chromium\src\base\debug\stack_trace_win.cc:286)
        logging::LogMessage::~LogMessage [0x00007FF9645068DC+92] (D:\chromium\src\base\logging.cc:600)
        HostedAppButtonContainer::LayoutInContainer [0x00007FF95DE837C2+178] (D:\chromium\src\chrome\browser\ui\views\frame\hosted_app_button_container.cc:283)
        GlassBrowserFrameView::LayoutTitleBar [0x00007FF95DC85963+585] (D:\chromium\src\chrome\browser\ui\views\frame\glass_browser_frame_view.cc:915)
        GlassBrowserFrameView::Layout [0x00007FF95DC867DE+122] (D:\chromium\src\chrome\browser\ui\views\frame\glass_browser_frame_view.cc:468)
        views::View::BoundsChanged [0x00007FF95B23E384+776] (D:\chromium\src\ui\views\view.cc:2198)
        views::View::SetBoundsRect [0x00007FF95B23DE42+258] (D:\chromium\src\ui\views\view.cc:346)
        views::NonClientView::LayoutFrameView [0x00007FF95B255B6F+111] (D:\chromium\src\ui\views\window\non_client_view.cc:138)
        views::NonClientView::Layout [0x00007FF95B255C9C+30] (D:\chromium\src\ui\views\window\non_client_view.cc:167)
        views::View::BoundsChanged [0x00007FF95B23E384+776] (D:\chromium\src\ui\views\view.cc:2198)
        views::View::SetBoundsRect [0x00007FF95B23DE42+258] (D:\chromium\src\ui\views\view.cc:346)
        views::FillLayout::Layout [0x00007FF95B23408F+99] (D:\chromium\src\ui\views\layout\fill_layout.cc:19)
        views::View::Layout [0x00007FF95B23F9D0+76] (D:\chromium\src\ui\views\view.cc:621)
        views::View::BoundsChanged [0x00007FF95B23E384+776] (D:\chromium\src\ui\views\view.cc:2198)
        views::View::SetBoundsRect [0x00007FF95B23DE42+258] (D:\chromium\src\ui\views\view.cc:346)
        views::View::SetBounds [0x00007FF95B23DD22+122] (D:\chromium\src\ui\views\view.cc:321)
        views::View::SetSize [0x00007FF95B23E51E+32] (D:\chromium\src\ui\views\view.cc:352)
        views::Widget::OnNativeWidgetSizeChanged [0x00007FF95B24DE67+49] (D:\chromium\src\ui\views\widget\widget.cc:1157)
        views::DesktopNativeWidgetAura::OnHostResized [0x00007FF95B278E24+98] (D:\chromium\src\ui\views\widget\desktop_aura\desktop_native_widget_aura.cc:1200)

Comment 1 by alancutter@chromium.org, Aug 8 

In addition, the location of the hosted app elements is too high vertically.
buggy-maximise-location.png
9.4 KB View Download

Comment 2 by mgiuca@chromium.org, Aug 20

Labels: M-70

Comment 3 by mgiuca@chromium.org, Aug 20

Blocking: -851845

Comment 4 by mgiuca@chromium.org, Aug 21 

The second bug in #1 is 876168.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/484ed22f82cbbee35c787dea089fd1303e8f5f82

commit 484ed22f82cbbee35c787dea089fd1303e8f5f82
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Aug 24 05:06:22 2018

Fix hosted app button layout when maximized in Windows 10

Hosted app windows using GlassBrowserFrameView (Windows 10 only)
had their controls and title misplaced when maximized.
This CL adds missing padding values to the titlebar layout.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354512&signed_aid=Tmrgizah9A_QhgrbRHXHFQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354513&signed_aid=h_aEa4bnb7fIu3UutTuNrA==&inline=1

Bug:  876168 ,  872203 
Change-Id: I9e4d3e1ff0776cfba09981cad30a0cfa39469e7c
Reviewed-on: https://chromium-review.googlesource.com/1183019
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585681}
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/glass_browser_frame_view_browsertest_win.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Comment 6 by alancutter@chromium.org, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment