New issue
Advanced search Search tips

Issue 872201 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3: Temporary mismatch between main and adaptive filter lengths cause DCHECK failure

Project Member Reported by peah@chromium.org, Aug 8

Issue description

When the adaptive filter length changes, in some cases the main and adaptive filters may have different lengths, which in turn can cause a DCHECK to fail on some cases. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/45e7281b862f16d3d29c1ae67c20705e71d2e372

commit 45e7281b862f16d3d29c1ae67c20705e71d2e372
Author: Per Åhgren <peah@webrtc.org>
Date: Thu Aug 09 18:41:05 2018

AEC3: Ensure that the shadow filter is adapted at each block

This CL ensures that the shadow filter is adapted at each block, which
avoids that a temporary filter length mismatch can occur between the
main and shadow filters.

Bug:  webrtc:9602 , chromium:872201 
Change-Id: I651812b4e3b134c6c5e1fe3df5ab78dbdb5c1fb4
Reviewed-on: https://webrtc-review.googlesource.com/93000
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24253}
[modify] https://crrev.com/45e7281b862f16d3d29c1ae67c20705e71d2e372/modules/audio_processing/aec3/subtractor.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10814c45a2507895d6a5f63e1d73fd822f0a3264

commit 10814c45a2507895d6a5f63e1d73fd822f0a3264
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 10 15:25:58 2018

Roll src/third_party/webrtc 5f0ce99c04eb..c97933fb82f8 (25 commits)

https://webrtc.googlesource.com/src.git/+log/5f0ce99c04eb..c97933fb82f8


git log 5f0ce99c04eb..c97933fb82f8 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 minyue@webrtc.org Clean up code regarding jitter buffer plot in event log visualizer.
2018-08-10 buildbot@webrtc.org Roll chromium_revision 86f8273e2f..f7e49bb7e6 (581886:582110)
2018-08-10 ivoc@webrtc.org Add command-line flag to enable the bugfix to postpone decoding after expand.
2018-08-10 terelius@webrtc.org Print timestamp-to-UTC map when event_log starts.
2018-08-10 nisse@webrtc.org Delete unused method RtpReceiver::CSRCs.
2018-08-10 mbonadei@webrtc.org Change visibility of some build targets that are publicly used.
2018-08-10 buildbot@webrtc.org Roll chromium_revision b0784bef91..86f8273e2f (581665:581886)
2018-08-10 nisse@webrtc.org Reland "Refactor RtpVideoStreamReceiver without RtpReceiver."
2018-08-09 peah@webrtc.org AEC3: Ensure that the shadow filter is adapted at each block
2018-08-09 sprang@webrtc.org Experimental improvements for simulcast screenshare
2018-08-09 alessiob@webrtc.org APM: render pre-processor moved before echo detector queuing.
2018-08-09 sakal@webrtc.org Add extended header containing frame ID to the generic packetizer.
2018-08-09 aleloi@webrtc.org Optionally disable digital gain control in ExperimentalAgc.
2018-08-09 magjed@webrtc.org Android: Allow YuvConverter to be reused
2018-08-09 oprypin@webrtc.org cq_name is no longer used and can and should be removed
2018-08-09 phoglund@webrtc.org Roll chromium_revision 474eca0589..b0784bef91 (581204:581665)
2018-08-09 oprypin@webrtc.org Add compile-only bots (used for binary size) to commit queue
2018-08-09 oprypin@webrtc.org Add post-submit builders without dcheck_always_on
2018-08-09 philipel@webrtc.org Remove RTPVideoHeader::vp9() accessors.
2018-08-09 danilchap@webrtc.org Remove raw extensions accessors from rtp packet
2018-08-09 sprang@webrtc.org SimulcastEncoderAdapter should not update maxQp for screencast
2018-08-09 titovartem@webrtc.org Remove old base64 header
2018-08-09 nisse@webrtc.org Add test CallPerfTest.PlaysOutAudioAndVideoInSyncWithoutClockDrift
2018-08-09 nisse@webrtc.org Delete unused constants from rtp_rtcp_config.h
2018-08-09 mbonadei@webrtc.org Making rtc_base:ptr_util and rtc_base:refcount public.


Created with:
  gclient setdep -r src/third_party/webrtc@c97933fb82f8

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:872201,chromium:b/112386285,chromium:None,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie0f047103689803c7eadfe059b10886153d22c2c
Reviewed-on: https://chromium-review.googlesource.com/1169939
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582173}
[modify] https://crrev.com/10814c45a2507895d6a5f63e1d73fd822f0a3264/DEPS

Status: Fixed (was: Started)
Labels: M-70

Sign in to add a comment