New issue
Advanced search Search tips

Issue 872197 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted blink of grey focus highlight is seen on 'Remove' button in chrome://settings/siteData

Reported by rp...@etouch.net, Aug 8

Issue description

Version: 70.0.3516.0 (Official Build)Revision a5cc86ce4806be7adb2876184069510bb6b95057-refs/branch-heads/3516@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/siteData
2. Now press 'Tab' key to bring grey focus on 'Remove' button in cookies entries list item
3. Now click on cookie entry and then click on 'Back navigation' arrow of subpage,observe 'Remove' button
 
Actual: Unwanted blink of grey focus highlight is seen on 'Remove' button after clicking on 'Back navigation' arrow of cookie subpage
Expected: Unwanted blink of grey focus highlight shouldn't be seen 'Remove' button after clicking on 'Back navigation' arrow of cookie subpage

This is regression issue, broken in ‘M 69’ and will soon update other info :
Good build: 69.0.3496.0  (Revision: 576217).
Bad build: 69.0.3497.0 (Revision: 576753).
 
You are probably looking for a change made after 576709 (known good), but no later than 576710 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e62e97671aa76b276794bc7a84e73090086c27df..942c9ea05ff7f10fd9333c25a0c2356dd41d5a46

Suspect : https://chromium.googlesource.com/chromium/src/+/942c9ea05ff7f10fd9333c25a0c2356dd41d5a46

From the CL above, assigning the issue to the concern owner 

@aee- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!
 
Actual_video.mp4
288 KB View Download
Expected_video.mp4
272 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ce86ed119a545b3e5836118738ee955008a318

commit 52ce86ed119a545b3e5836118738ee955008a318
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Aug 10 18:52:23 2018

Settings: site-data, focus on site select button before navigating away

Bug:  872197 
Change-Id: Ie98bf0737a9755312fda763053c9c15316b566be
Reviewed-on: https://chromium-review.googlesource.com/1168283
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582273}
[modify] https://crrev.com/52ce86ed119a545b3e5836118738ee955008a318/chrome/browser/resources/settings/site_settings/site_data.js

Status: Fixed (was: Started)
Labels: TE-Verified-M70 TE-Verified-70.0.3521.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.6)OS with latest Canary Chrome version : 70.0.3521.0 and the issue is Fixed.Hence adding TE Verified Label.

Kindly refer the attached screen cast for reference.
Fixed_video.mp4
288 KB View Download

Sign in to add a comment