New issue
Advanced search Search tips

Issue 872176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.5% regression in octane at 581201:581216

Project Member Reported by toyoshim@chromium.org, Aug 8

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=872176

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=2979acdb98f3500f355d335ef9a585b6d5d8c92038e6cf304bd42e9dc72040f8


Bot(s) for this bug's original alert(s):

Android Nexus6 WebView Perf
Cc: sigurds@chromium.org
Owner: sigurds@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/149d66b4640000

[arm] Use constant pool for off-heap targets by sigurds@chromium.org
https://chromium.googlesource.com/v8/v8/+/cd28595110bc0368a141eab0f05a9ea0781e3dc4
1.056e+04 → 1.011e+04 (-457.3)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2a3b6df5150c9a7e17ea88d949589463d4c0b52c

commit 2a3b6df5150c9a7e17ea88d949589463d4c0b52c
Author: Sigurd Schneider <sigurds@chromium.org>
Date: Thu Aug 16 09:36:03 2018

Revert "[arm] Use constant pool for off-heap targets"

This reverts commit cd28595110bc0368a141eab0f05a9ea0781e3dc4.

Reason for revert: No size improvements, but 5% regression on octane/NavierStrokes:
https://chromeperf.appspot.com/report?sid=ebcd213df609b4ff31b0b25b5c8aab9d0738ff46f623161bdcdbb6f594112761&start_rev=579365&end_rev=582538

Original change's description:
> [arm] Use constant pool for off-heap targets
>
> This CL puts off-heap targets (i.e. code addresses for embedded builtins)
> in the constant pool on ARM.
>
> We are landing this CL to evaluate impact on benchmarks and code size,
> and expect to revert it once we have gathered that data.
>
> Bug:  v8:6666 
>
> Change-Id: If4935a6fb162cd1ffb34489c6fa9630f10ca2c9f
> Reviewed-on: https://chromium-review.googlesource.com/1154924
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54914}

TBR=sigurds@chromium.org,jgruber@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  v8:6666 ,  chromium:872176 
Change-Id: Icd0019c7f0c890d0eb09ddc2a74745c6b68db263
Reviewed-on: https://chromium-review.googlesource.com/1172482
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55151}
[modify] https://crrev.com/2a3b6df5150c9a7e17ea88d949589463d4c0b52c/src/arm/assembler-arm.cc
[modify] https://crrev.com/2a3b6df5150c9a7e17ea88d949589463d4c0b52c/src/arm/assembler-arm.h
[modify] https://crrev.com/2a3b6df5150c9a7e17ea88d949589463d4c0b52c/src/arm64/macro-assembler-arm64.cc

Status: Fixed (was: Assigned)
Metric has recovered after revert.

Sign in to add a comment