Close icon animation looks weird when closing split screen |
||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1) Open two apps, drag one to split screen, overview should show on the other split (2) Drag the split divider towards the screen edge of the overview split (3) What is the expected result? What happens instead? It's a little weird when the close icon could cover the app icon and eventually move past the app icon: https://photos.app.goo.gl/xNban19PSb7FpMoN9 Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 8
,
Aug 8
Thanks for filing this, Kejia. I mentioned it the other day to Sammie but good to have it documented. My guidance would be that overview should shrink until it reaches the 1/3 width and then be increasingly translated offscreen rather than reduced in size as the divider pushes further from there.
,
Aug 8
Note this would still happen if we have enough windows, though 90+% have 4 or less windows open so it should look fine. Also happens with tons of windows, even without the divider dragged or even in split screen. Also, I cannot access the link, but i know what it looks like, so i can get started, though it would be nice to have a working reference.
,
Aug 8
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1751c4de5c18ba49a54e260798ddfad56cafaa14 commit 1751c4de5c18ba49a54e260798ddfad56cafaa14 Author: Sammie Quon <sammiequon@google.com> Date: Fri Aug 10 01:06:56 2018 splitview: Add minimum bounds for overview grid when dragging divider. When we reach one third of work area, stop shrinking the overview bounds and instead start sliding it out off screen. Test: added test Bug: 872141 Change-Id: I4d42e5943485c9a4d96205d1a1870823305b49e9 Reviewed-on: https://chromium-review.googlesource.com/1169974 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581995} [modify] https://crrev.com/1751c4de5c18ba49a54e260798ddfad56cafaa14/ash/wm/overview/window_selector.cc [modify] https://crrev.com/1751c4de5c18ba49a54e260798ddfad56cafaa14/ash/wm/overview/window_selector_unittest.cc
,
Aug 10
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kejiashao@chromium.org
, Aug 8