New issue
Advanced search Search tips

Issue 872130 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 757440



Sign in to add a comment

48.7% regression in rendering.desktop at 579719:579776

Project Member Reported by toyoshim@chromium.org, Aug 8

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=872130

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4d9ade08e0a16ce4d3d9c0fdc19a89d626a64b0a3827e7698f7d34cb1fd68004


Bot(s) for this bug's original alert(s):

Win 7 Perf
Cc: keishi@chromium.org
Owner: keishi@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17f6d820640000

Oilpan: Enable incremental marking by default by keishi@chromium.org
https://chromium.googlesource.com/chromium/src/+/d92ab8be365f7c52d1ead03f2d2f3a75510957f3
0.6806 → 0.9384 (+0.2579)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Blocking: 757440
Cc: mlippautz@chromium.org haraken@chromium.org
There is a easily noticeable difference between incremetanl marking off/on.
https://drive.google.com/file/d/12Fi66V_kkO19nwDYX1i-177yQl6hSnSt/view?usp=sharing
Trace reveals no incremental marking being executed. I will take a closer look.
The video was not representative. Something in my profile or something must have made it slow. I am retaking traces using telemetry.
I cannot replicate this locally. queueing_durations show 10% improvement :/
put_get_image_data.html
3.0 MB View Download
Kind of replicates on pinpoint bots. I've also taken traces but incremental marking GC does not seem to be executed at all. I think this test is just very sensitive to V8 GC timing changes.

--pageset-repeat=20
Win 7 Perf https://pinpoint-dot-chromeperf.appspot.com/job/11e08cf8640000
linux-perf https://pinpoint-dot-chromeperf.appspot.com/job/11a747a4640000
Win 7 Nvidia GPU Perf https://pinpoint-dot-chromeperf.appspot.com/job/14ccca64640000

--pageset-repeat=80
linux-perf https://pinpoint-dot-chromeperf.appspot.com/job/11abc29c640000
Status: WontFix (was: Assigned)
The benchmark improved to an extend that this one is not relevant anymore.

Sign in to add a comment