Windows 10 PWA: Title text and caption icons disagree on colours |
|||||||
Issue descriptionChrome Version: 70 OS: Win10 What steps will reproduce the problem? (1) Navigate to: fast-lute.glitch.me (2) Menu > install Fast Lute What is the expected result? Title bar elements should use consistent colours. What happens instead? Text is white and caption buttons are black. They are both white on Chrome OS.
,
Aug 20
,
Aug 20
,
Aug 21
Good old santatracker.google.com exhibits this bug as well.
,
Aug 25
Updated screenshot for WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1186929
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e7a9ee8ed02f71e8b5cb31e551c8611babedd59 commit 1e7a9ee8ed02f71e8b5cb31e551c8611babedd59 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Aug 27 10:46:14 2018 Use consistent colors for GlassBrowserFrameView titlebar features This CL fixes color inconsistency between the title and the caption buttons on Windows 10 when theme colors are used in PWA windows. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354609&signed_aid=XZviD7H5PrdO2M-73ui7Tw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354795&signed_aid=Av8_PIND8_gosBPPahgKFw==&inline=1 Bug: 872118 Change-Id: I7dcc27aa480ca43746ca65bb8a60561d99e47e99 Reviewed-on: https://chromium-review.googlesource.com/1186929 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#586228} [modify] https://crrev.com/1e7a9ee8ed02f71e8b5cb31e551c8611babedd59/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/1e7a9ee8ed02f71e8b5cb31e551c8611babedd59/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/1e7a9ee8ed02f71e8b5cb31e551c8611babedd59/chrome/browser/ui/views/frame/windows_10_caption_button.cc
,
Aug 27
,
Aug 28
Tried to test the issue on chrome 70.0.3516.0 using Windows 10, build without fix. Steps: ------ 1. Launched chrome 2. Entered "fast-lute.glitch.me" in omnibox and can observe the same error as in comment #1. Attached is the screenshot for reference. @alancutter@: Could you please review the attached screenshot and and help us in verifying the fix and if possible could you please provide proper steps to install PWA on windows. Thanks..!
,
Aug 28
,
Aug 28
#10 sorry, my instructions were unclear. They should be: (1) Navigate to: fast-lute.glitch.me (2) Menu > Install Fast Lute |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by alancutter@chromium.org
, Aug 84.8 KB
4.8 KB View Download