Issue 872602  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a1ad4a1cde048138003b8cc01cf75fba8b9e58c

commit 3a1ad4a1cde048138003b8cc01cf75fba8b9e58c
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Aug 10 18:50:30 2018

[Picture in Picture] Update close button style.

This change updates the close button style. The color of the 'x' is now
white. There is no background unless the user hovers over the icon. In
this case, there is a grey circular background.

As part of this change, CloseIconButton is created to account for the
hover behavior.

Bug:  872098 
Change-Id: I90a53c5e42d6377db4ee45b47633689315865c18
Reviewed-on: https://chromium-review.googlesource.com/1168732
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582271}
[modify] https://crrev.com/3a1ad4a1cde048138003b8cc01cf75fba8b9e58c/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/3a1ad4a1cde048138003b8cc01cf75fba8b9e58c/chrome/browser/ui/views/overlay/close_image_button.cc
[add] https://crrev.com/3a1ad4a1cde048138003b8cc01cf75fba8b9e58c/chrome/browser/ui/views/overlay/close_image_button.h
[modify] https://crrev.com/3a1ad4a1cde048138003b8cc01cf75fba8b9e58c/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/3a1ad4a1cde048138003b8cc01cf75fba8b9e58c/chrome/browser/ui/views/overlay/overlay_window_views.h

Able to reproduce this issue on build without fix, hence verifying the fix on latest canary 70.0.3521.0 using Mac 10.13.6, Windows 10 and Debian.

Now close icon is white, there is no background unless the user hovers over the icon.Upon hover, there is a grey circular background. Attaching screencast for reference.

As fix is working as expected adding Verified labels.

Thanks!

Deleted: Withfix_Close icon.webm 2.1 MB

	Withfix_Close icon.webm 2.1 MB View Download

Requesting Merge to 69 as it's a UI polish requested by UX team. It should only impact the feature which is guarded by a Finch flag.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M69 branch 3497 based on comment #4 and #5. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb252a5db909382866067e13e8da532d9ec183c1

commit fb252a5db909382866067e13e8da532d9ec183c1
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon Aug 13 20:40:18 2018

[Picture in Picture] Update close button style.

This change updates the close button style. The color of the 'x' is now
white. There is no background unless the user hovers over the icon. In
this case, there is a grey circular background.

As part of this change, CloseIconButton is created to account for the
hover behavior.

Bug:  872098 
Change-Id: I90a53c5e42d6377db4ee45b47633689315865c18
Reviewed-on: https://chromium-review.googlesource.com/1168732
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582271}(cherry picked from commit 3a1ad4a1cde048138003b8cc01cf75fba8b9e58c)
Reviewed-on: https://chromium-review.googlesource.com/1173079
Cr-Commit-Position: refs/branch-heads/3497@{#588}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/fb252a5db909382866067e13e8da532d9ec183c1/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/fb252a5db909382866067e13e8da532d9ec183c1/chrome/browser/ui/views/overlay/close_image_button.cc
[add] https://crrev.com/fb252a5db909382866067e13e8da532d9ec183c1/chrome/browser/ui/views/overlay/close_image_button.h
[modify] https://crrev.com/fb252a5db909382866067e13e8da532d9ec183c1/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/fb252a5db909382866067e13e8da532d9ec183c1/chrome/browser/ui/views/overlay/overlay_window_views.h

Able to reproduce this issue on build without fix, hence verifying the fix on latest beta 69.0.3497.42 using Mac 10.13.6, Windows 10 and Debian.

Now close icon is white, there is no background unless the user hovers over the icon.Upon hover, there is a grey circular background. Attaching screencast for reference.

As fix is working as expected adding Verified labels.

Thanks!

Deleted: M69_withfix_closeicon.webm 1.2 MB

	M69_withfix_closeicon.webm 1.2 MB View Download