New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872097 link

Starred by 2 users
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Aug 10
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[PIP] Circular background to controls is pixelated.

Project Member Reported by apaci...@chromium.org, Aug 8 
On some platforms, the background has slightly jagged edges. Update vector file with one from UX to smooth it out more.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c52f2feffc76be3c31930a20d25023907c9abeec

commit c52f2feffc76be3c31930a20d25023907c9abeec
Author: Jennifer Apacible <apacible@chromium.org>
Date: Wed Aug 08 22:27:02 2018

[Picture in Picture] Update Picture-in-Picture background icon.

This change updates the background icon supplied by the UX designer.

Bug:  872097 
Change-Id: I82ce3f9fd1509ecf42045bd0ebf0179f72736f6a
Reviewed-on: https://chromium-review.googlesource.com/1166445
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581708}
[modify] https://crrev.com/c52f2feffc76be3c31930a20d25023907c9abeec/chrome/app/vector_icons/picture_in_picture_control_background.icon

Comment 2 by apaci...@chromium.org, Aug 10

Status: Fixed (was: Started)

Comment 3 by mlamouri@chromium.org, Aug 13

Cc: mlamouri@chromium.org
Labels: Merge-Request-69
Requesting Merge to 69 as it's a UI polish requested by UX team. It should only impact the feature which is guarded by a Finch flag.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Aug 13

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #3, Please merge ASAP. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 13

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e349b301ad6df6bb4b8adb0513e2138eb64d02

commit 61e349b301ad6df6bb4b8adb0513e2138eb64d02
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon Aug 13 19:33:22 2018

[Picture in Picture] Update Picture-in-Picture background icon.

This change updates the background icon supplied by the UX designer.

Bug:  872097 
Change-Id: I82ce3f9fd1509ecf42045bd0ebf0179f72736f6a
Reviewed-on: https://chromium-review.googlesource.com/1166445
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581708}(cherry picked from commit c52f2feffc76be3c31930a20d25023907c9abeec)
Reviewed-on: https://chromium-review.googlesource.com/1173132
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#576}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/61e349b301ad6df6bb4b8adb0513e2138eb64d02/chrome/app/vector_icons/picture_in_picture_control_background.icon
►

Sign in to add a comment