Picture-in-Picture: always check that the player delegate_id matches. |
|||||||||
Issue descriptionWe currently loosy check for PIP player matching in OnMediaPlaying and OnMeodiaPaused. I believe this is no longer needed with a fix I'm about to land. Because the fix will be merged, this bug is to update the check on trunk.
,
Sep 25
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0dc584775e65fc731a62ccbbb1dceb09fc4a86e commit c0dc584775e65fc731a62ccbbb1dceb09fc4a86e Author: François Beaufort <beaufort.francois@gmail.com> Date: Wed Oct 10 18:58:12 2018 Picture-in-Picture: check that pip_player matches player_id. This makes sure we don't reset media_player_id_ when switching non-Mediastream Picture-in-Picture video to a Mediastream video. Bug: 872066 , 893830 Change-Id: Ie84b51ae1f7e0ac822743dfeb948bea6afd076ba Reviewed-on: https://chromium-review.googlesource.com/c/1273515 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#598428} [modify] https://crrev.com/c0dc584775e65fc731a62ccbbb1dceb09fc4a86e/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/c0dc584775e65fc731a62ccbbb1dceb09fc4a86e/chrome/test/data/media/picture-in-picture/window-size.html [modify] https://crrev.com/c0dc584775e65fc731a62ccbbb1dceb09fc4a86e/content/browser/media/media_web_contents_observer.cc
,
Oct 10
,
Oct 10
,
Oct 11
,
Oct 11
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 11
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebacf403c9b00332746b18d085a25061078a29ad commit ebacf403c9b00332746b18d085a25061078a29ad Author: François Beaufort <beaufort.francois@gmail.com> Date: Thu Oct 11 20:16:03 2018 Picture-in-Picture: check that pip_player matches player_id. This makes sure we don't reset media_player_id_ when switching non-Mediastream Picture-in-Picture video to a Mediastream video. Bug: 872066 , 893830 Change-Id: Ie84b51ae1f7e0ac822743dfeb948bea6afd076ba Reviewed-on: https://chromium-review.googlesource.com/c/1273515 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#598428}(cherry picked from commit c0dc584775e65fc731a62ccbbb1dceb09fc4a86e) Reviewed-on: https://chromium-review.googlesource.com/c/1277985 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#968} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/ebacf403c9b00332746b18d085a25061078a29ad/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/ebacf403c9b00332746b18d085a25061078a29ad/chrome/test/data/media/picture-in-picture/window-size.html [modify] https://crrev.com/ebacf403c9b00332746b18d085a25061078a29ad/content/browser/media/media_web_contents_observer.cc
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebacf403c9b00332746b18d085a25061078a29ad Commit: ebacf403c9b00332746b18d085a25061078a29ad Author: beaufort.francois@gmail.com Commiter: beaufort.francois@gmail.com Date: 2018-10-11 20:16:03 +0000 UTC Picture-in-Picture: check that pip_player matches player_id. This makes sure we don't reset media_player_id_ when switching non-Mediastream Picture-in-Picture video to a Mediastream video. Bug: 872066 , 893830 Change-Id: Ie84b51ae1f7e0ac822743dfeb948bea6afd076ba Reviewed-on: https://chromium-review.googlesource.com/c/1273515 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#598428}(cherry picked from commit c0dc584775e65fc731a62ccbbb1dceb09fc4a86e) Reviewed-on: https://chromium-review.googlesource.com/c/1277985 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#968} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by fbeaufort@chromium.org
, Sep 25