In tab switcher mode youtube video flashes purple |
|||
Issue descriptionPrecondition: **Enable the flag 'Surfacelayer objects for videos' from Chrome://flags Steps to reproduce: 1.Launch Chrome 2.Search or Enter URL(m.youtube.com) 3.Play video 4.Open New Tab and click on any article 5.Click on tab switcher button 6.Click on tab with youtube video 7.Play video Observed behavior: youtube video flashes purple before playing as normal Expected behavior: Video shouldn't flash purple Frequency:100%
,
Aug 8
Its actually the reverse, an old frame comes in, and the SurfaceManager no longer as reference to it.
,
Aug 8
You're probably not assigning the fallback surface ID somewhere.
,
Aug 8
Does this only show up on Android?
,
Aug 8
FWIW, I've seen the same isuse when swapping video src in some cases. Though, on a release build, the frame stays black and would be pink on debug. Given that YouTube is clearing the src when the page is no longer visible, I wonder if we may hit the same bug here.
,
Aug 8
to note, it doesnt seem to repro on mobile outside of Youtube, so it seems like it could be the same bug
,
Aug 8
re c#3: fallback should be set OnFirstSurfaceActivation to the newly-activated surface, along with the primary in SurfaceLayerBridge::OnFirst...() when the CompositorFrameSink is destroyed, will the fallback surface ID continue to work?
,
Aug 8
If the GPU process crashes then no, the fallback will stop working. We should clear the fallback at that point.
,
Aug 8
wait -- did the gpu process crash in this case? i thought nothing like that happened. i thought the renderer just closed the CompositorFrameSink. either way, but that's handy info -- we don't ever clear it, if i remember.
,
Aug 8
The GPU isnt crashing, we are just clearing the src.
,
Aug 8
,
Aug 8
Try enabling surface synchronization? I'm kind of surprised this is happening. --enable-surface-synchronization --enable-features=SurfaceSynchronization
,
Aug 8
I am able to repro a similar issue on desktop (not m.youtube.com) and these flags did not help :(
,
Aug 8
I haven't been able to repro?
,
Aug 10
On desktop, using a debug build from trunk, you should be able to see a pink PIP window with one of the steps from bug 870853 . lethalantidote@, were you using a debug Chrome Android when you found that issue? On a release build, I see a black frame which would match what I see on desktop.
,
Aug 10
Yes it was a debug Chrome Android build. Sorry for omitting that from the repro steps.
,
Aug 29
Are you still seeing this bug on the latest canary builds? We've been doing a lot of work on surface references and this bug might just be gone now.
,
Aug 29
Im no longer seeing the error message.
,
Aug 30
@mlamouri, mind checking if this still exists on desktop?
,
Aug 31
I can't see any console error nor pink flash on the desktop repro too. Closing this. |
|||
►
Sign in to add a comment |
|||
Comment 1 by lethalantidote@chromium.org
, Aug 7