New issue
Advanced search Search tips

Issue 872052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Move the new selector item to the first window at overview grid

Project Member Reported by minch@chromium.org, Aug 7

Issue description

Start tab dragging or drag an app window from top in tablet mode will enter overview mode, and a new selector item window will be added at the end of current windows in overview grid.

Move the new selector item as the first window in overview grid instead.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b6e560a9511cf934ba7708faaaa2c0aff63c78

commit 97b6e560a9511cf934ba7708faaaa2c0aff63c78
Author: Min Chen <minch@google.com>
Date: Fri Aug 10 00:11:27 2018

Put the new selector item as the first one in overview grid.

Bug:  872052 
Test: SplitViewTabDraggingTest.ShowNewWindowItemWhenDragStarts
Change-Id: Ib7a563d350fb5d789495518b414f7a319bc9063b
Reviewed-on: https://chromium-review.googlesource.com/1168592
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581969}
[modify] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc

Status: Fixed (was: Started)

Sign in to add a comment