New issue
Advanced search Search tips

Issue 872031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: Manufacturer and Model selection area is missing in Edit Printer dialog

Project Member Reported by x...@chromium.org, Aug 7

Issue description

Chrome Version: 70.0.3516.0
OS: Chrome

What steps will reproduce the problem?
(1) Go to chrome://settings/cupsPrinters
(2) Click on Add Printer button to add a printer
(3) Click on the newly added printer to edit it

What is the expected result?
The manufacturer and model selection drop down box should be seen

What happens instead?
They are missing.


Not sure when it regressed. 
 
Labels: M-70
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c2ca19fd5e5c9c489df25f258bb03d8e64751c2

commit 4c2ca19fd5e5c9c489df25f258bb03d8e64751c2
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Aug 13 20:02:41 2018

CUPS: fix the edit printer dialog regression.

The 'drop-down-search-box' was extracted to 'cr-searchable-drop-down'
element in
https://chromium-review.googlesource.com/c/chromium/src/+/1145774.
But 'drop-down-search-box' was not replaced in the edit printer dialog.

Bug:  872031 
Change-Id: Ia78cec9d26664a3e8d66e65c30ea6b4b0cf9117c
Reviewed-on: https://chromium-review.googlesource.com/1167722
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582677}
[modify] https://crrev.com/4c2ca19fd5e5c9c489df25f258bb03d8e64751c2/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html

Status: Fixed (was: Started)

Sign in to add a comment