New issue
Advanced search Search tips

Issue 872025 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"fast/css-grid-layout/crash-large-positions.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 7

Issue description

"fast/css-grid-layout/crash-large-positions.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9mYXN0L2Nzcy1ncmlkLWxheW91dC9jcmFzaC1sYXJnZS1wb3NpdGlvbnMuaHRtbAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: svil...@igalia.com
Status: Assigned (was: Untriaged)
Failure expectations added in https://chromium-review.googlesource.com/c/chromium/src/+/1166562.

Assigning based on git blame.
Cc: svil...@igalia.com jfernan...@igalia.com r...@igalia.com
Components: Blink>Layout>Grid
This might be related to https://chromium.googlesource.com/chromium/src/+/b9351e20a47f21d28527b55d49e2191f0a08845f

Inserting big spanning grid items is now slower than before:
https://bugs.chromium.org/p/chromium/issues/detail?id=868517

And we're getting timeouts for this test that has a huge grid item:
    <div id="item" style="grid-column-start: 5000000000; grid-column-end: -5000000000; grid-row-start: 5000000000; grid-row-end: -5000000000;"></div>

svillar@ could you take a look to this?
Maybe the test should be marked as timeout and that's all to avoid the flakiness.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/167a1685c3314ac1acf6ee4e759272bca54839b7

commit 167a1685c3314ac1acf6ee4e759272bca54839b7
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Aug 08 04:55:28 2018

Disable Layout test flaky fail, timeout, crash

TBR=futhark@chromium.org

Bug:  869470 ,871105,872025, 871416 
Change-Id: Iab76b2330c889d36243f95f3c105f9bba7568819
Reviewed-on: https://chromium-review.googlesource.com/1166564
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581476}
[modify] https://crrev.com/167a1685c3314ac1acf6ee4e759272bca54839b7/third_party/WebKit/LayoutTests/TestExpectations

Owner: r...@igalia.com
Yes it's related to that change as inserting huge items is much slower right now. Perhaps we could reduce a bit the size of the item being inserted as it should be enough to tests.
Owner: ----
Status: Available (was: Assigned)
I didn't find time this week for this sorry and I'm leaving on holidays.
Let's see if jfernandez@ or you can take a look at some point.
Labels: -Pri-1 Pri-2
Owner: jfernan...@igalia.com
Status: Assigned (was: Available)

Sign in to add a comment