"This seems like it will not be achievable by M-70 (at time of bug creation, 15 working days from branch date). 

Maybe we can come up with a faster to implement solution."

This is a crucial part of home-cher (in addition to the shield),  there is no simpler solution :s

Omri came up with a solution for this that could work in the short term.

The issue is in animating the shadows with a mask layer. We could do as overview does when enlarging panels, which is remove the shadow, animate the mask layer, then draw the larger shadow.

It's not perfect but it would only look strange while the animation is occuring.

This should be a target for refactoring at a later date so we can have the full animation

After talking to weidongg@, the other issue is that we will have to enlarge the size of App icons in multiple views, which involves complex layout changes to multiple files. This change will take a large amount of time even with the above short-cut.

What would be the cost of change the label color from ##F1F3F4 to #202124 when the wallpaper is identified as "white"? I believe we have such a logic for themes in Chrome, might be something we can adapt for here.

We have access to the MD wallpaper colors (DM etc), would we use this to determine the wallpaper color threshold? Or is there some other color utility we would be using.

That would be something else, like understanding where on the spectrum of brightness the dominant color is and adapting the color accordingly.

For now it's ok however as we've fixed the shield and shadow with Weidong.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e16127ace1cc1a20b767a4c7351185fbb0ad1f74

commit e16127ace1cc1a20b767a4c7351185fbb0ad1f74
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Aug 10 16:55:12 2018

Mitigate issue with light color icon and background.

1. To add an icon shadow without affecting its bounds, create a new
   image view for the shadow and hide it behind the icon. In this case,
   dragged icon does not have shadow, UX is fine with this.
2. Add shadow for app title.
3. Change folder bubble color
4. Change app list background shield color.

Demo: https://screenshot.googleplex.com/EWBDpOrpUTa

Bug:  872012 

Change-Id: I8e2f1ab5cb3bd6ac980ebee0b549e0a7c86f96d2
Reviewed-on: https://chromium-review.googlesource.com/1168583
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582210}
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/model/folder_image.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/model/folder_image.h
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/views/app_list_folder_view.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/views/app_list_item_view.h
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/public/cpp/app_list/app_list_config.cc
[modify] https://crrev.com/e16127ace1cc1a20b767a4c7351185fbb0ad1f74/ash/public/cpp/app_list/app_list_config.h

 Issue 868530  has been merged into this issue.