Buildbot tag cbb_master_buildbucket_id is "None" |
|||
Issue descriptionI've seen a few master-release builds that have the cbb_master_buildbucket_id set to "None". Example Buildbucket ID 8938972521659289680 (https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8938972521659289680&_h=8&). This is mostly just an FYI for the CI API folks, you'll need to handle this edge case.
,
Aug 7
That makes sense, seeing as the tags are just a string[]. So we should just take "None" to mean null in tags. This still needs to be handled by the CI API though, as the tags we care about are parsed into first-class Proto fields like `Build.parent_id` and we don't want every client to be surprised by the appearance of "None" instead of null.
,
Aug 7
This seems like a bug in the tag generation code; "None" is a python-specific implementation detail. It should either omit the tag or have an empty value like for cbb_email in that result.
,
Aug 7
Oh.. you mean a literal "None". Yes, that is a bug. I revamped the relevant code a few months ago, and I think the current version should be resistant to that behavior since it explicitly filters empty properties/tags. Are you seeing this only on builds that ran a long time ago? Branched builds? Or TOT?
,
Aug 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dgarr...@chromium.org
, Aug 7