New issue
Advanced search Search tips

Issue 871986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

chromevox_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 7

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of hubbe@google.com

chromevox_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f024069809d20c96ddd628f6a96095b87b714e0b

commit f024069809d20c96ddd628f6a96095b87b714e0b
Author: Fredrik Hubinette <hubbe@chromium.org>
Date: Tue Aug 07 22:10:29 2018

Revert "Handle legacy camera app in consolidated icon"

This reverts commit 5e61a5b773e5da7724683b7823690ba2f96e9238.

Reason for revert: Seems to be calling LSAN problems on linux:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

BUG:   871986 

Original change's description:
> Handle legacy camera app in consolidated icon
> 
> This CL does 2 things:
> 1. Hide legacy camera app icon
> 2. Launch legacy camera app (com.android.camera2) when
> com.google.android.GoogleCameraArc is not available.
> 
> Sometimes when devices are upgraded from version with Camera2 installed,
> GCA still has com.android.camera2 as the package name. That's why this
> CL is needed.
> 
> Bug: b:112121210
> Test: Tested on nautilus that after this CL, the legacy camera app icon
> 
> Change-Id: I16e4d29d4cb538bd2ad6607456bcf4667be1f188
> Reviewed-on: https://chromium-review.googlesource.com/1127899
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
> Cr-Commit-Position: refs/heads/master@{#581047}

TBR=stevenjb@chromium.org,shenghao@google.com

Change-Id: Ibd24eb5f9821e23a3986fbabc45db3d3ed14c81b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:112121210
Reviewed-on: https://chromium-review.googlesource.com/1166004
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581359}
[modify] https://crrev.com/f024069809d20c96ddd628f6a96095b87b714e0b/chrome/browser/ui/app_list/arc/arc_app_utils.cc
[modify] https://crrev.com/f024069809d20c96ddd628f6a96095b87b714e0b/chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc

Owner: shenghao@chromium.org
Status: Assigned (was: Available)
Status: Fixed (was: Assigned)
The root cause of the ASAN failure was https://chromium-review.googlesource.com/c/chromium/src/+/1167147

Sign in to add a comment