New issue
Advanced search Search tips

Issue 871985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

overview: the window selector item's close button is not properly updated

Project Member Reported by x...@chromium.org, Aug 7

Issue description

Chrome Version: 70.0.3516.0
OS: Chrome

What steps will reproduce the problem?
(1) Enter tablet mode, enter overview
(2) Drag one window to snap to one side of the screen

What is the expected result?
All other windows are re-positioned properly in overview in the other side of the screen

What happens instead?
The close buttons of the overview windows are not properly updated

It might be recent regression.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71135040b08c3aa42ea549e08ff4ad8bbce1ef4e

commit 71135040b08c3aa42ea549e08ff4ad8bbce1ef4e
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Aug 09 21:36:04 2018

overview: The window selector item close button is not properly updated.

Test: manual
Bug:  871985 
Change-Id: I3747ce934f186acd677252ce22d748f4fe853907
Reviewed-on: https://chromium-review.googlesource.com/1166326
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581902}
[modify] https://crrev.com/71135040b08c3aa42ea549e08ff4ad8bbce1ef4e/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/71135040b08c3aa42ea549e08ff4ad8bbce1ef4e/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/71135040b08c3aa42ea549e08ff4ad8bbce1ef4e/ash/wm/overview/window_selector_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment