GPU benchmarking should support different mouse wheel scroll option, such as scroll_by_page and has_precise_scrolling_deltas.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7 commit c7b76cc1473f14e65e9a2af10dc23c40abfad5d7 Author: Lan Wei <lanwei@chromium.org> Date: Wed Aug 15 14:57:07 2018 Add wheel scroll options to GpuBenchmarking In GpuBenchmarking, for mouse wheel and touchpad scroll, we want to add "has_precise_scrolling_deltas" scroll option to GpuBenchmarking::SmoothScrollBy. Bug: 871970 Change-Id: I456db492e2a7fdab35263efe931d089b400a9e3d Reviewed-on: https://chromium-review.googlesource.com/1166165 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#583249} [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/common/input/synthetic_smooth_scroll_gesture_params.cc [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/common/input/synthetic_smooth_scroll_gesture_params.h [modify] https://crrev.com/c7b76cc1473f14e65e9a2af10dc23c40abfad5d7/content/renderer/gpu/gpu_benchmarking_extension.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9 commit 7f6178415cc857a0aa599ed1244ab99bb2bf8cf9 Author: Lan Wei <lanwei@chromium.org> Date: Thu Aug 23 23:39:56 2018 Add wheel scroll options "scroll_by_page" to GpuBenchmarking In GpuBenchmarking, for mouse wheel and touchpad scroll, we want to add "scroll_by_page" scroll option to GpuBenchmarking::SmoothScrollBy. Bug: 871970 Change-Id: If73cc2bb41a77499cfc6215b5d8fde09f33f6caa Reviewed-on: https://chromium-review.googlesource.com/1174993 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#585656} [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/common/input/synthetic_smooth_scroll_gesture_params.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/common/input/synthetic_smooth_scroll_gesture_params.h [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/common/input/synthetic_web_input_event_builders.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/common/input/synthetic_web_input_event_builders.h [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/common/input_messages.h [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/content/renderer/gpu/gpu_benchmarking_extension.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/8a6d66b9d2859cde8595eb9860a4ff5ef72b8445/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scroll-by-page-expected.txt [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-scroll-by-page.html [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/third_party/WebKit/LayoutTests/resources/gesture-util.js [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/third_party/WebKit/LayoutTests/virtual/threaded/animations/invisible-composited-animations-prevent-scroll.html [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/ui/events/blink/web_input_event.cc [modify] https://crrev.com/7f6178415cc857a0aa599ed1244ab99bb2bf8cf9/ui/events/event_constants.h
Comment 1 by bugdroid1@chromium.org
, Aug 15