Currently, skylab_test_push only ensures that kicked of push-to-prod suite succeeds. This does not guarantee that TKO results are inserted correctly. skylab_test_push should separately verify the TKO results are correctly inserted.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/665cfad3f4b360a28d0c432e06806e1ea430f8f6 commit 665cfad3f4b360a28d0c432e06806e1ea430f8f6 Author: Xixuan Wu <xixuan@chromium.org> Date: Fri Aug 17 16:50:45 2018 autotest: Move some variables to test_push_common for sharing. BUG= chromium:871968 TEST=Ran test_push on staging. Change-Id: Ibc239e2c51f9bb06ddea1009ae00827d23c6be3a Reviewed-on: https://chromium-review.googlesource.com/1171192 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/665cfad3f4b360a28d0c432e06806e1ea430f8f6/venv/skylab_staging/test_push.py [modify] https://crrev.com/665cfad3f4b360a28d0c432e06806e1ea430f8f6/site_utils/test_push.py [add] https://crrev.com/665cfad3f4b360a28d0c432e06806e1ea430f8f6/site_utils/test_push_common.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8e327e2458092bf3a667b257f7add15414da1e48 commit 8e327e2458092bf3a667b257f7add15414da1e48 Author: Xixuan Wu <xixuan@chromium.org> Date: Fri Aug 17 21:45:14 2018 autotest: Add tko function to get child test results for skylab suite. BUG= chromium:871968 TEST=Ran on staging server. Change-Id: If351458d9a7ef6b621dcc44dcdf65a47b19baef5 Reviewed-on: https://chromium-review.googlesource.com/1171513 Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/8e327e2458092bf3a667b257f7add15414da1e48/tko/db.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/84a834fa96d1ea94ce132995905a8ad3a2463322 commit 84a834fa96d1ea94ce132995905a8ad3a2463322 Author: Xixuan Wu <xixuan@chromium.org> Date: Fri Aug 17 22:18:21 2018 autotest: Refactor for test_push for future skylab test_push's use. BUG= chromium:871968 TEST=Unittest. Change-Id: I829f2066db32231b94f853c2fb46a02351af4a51 Reviewed-on: https://chromium-review.googlesource.com/1180242 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/84a834fa96d1ea94ce132995905a8ad3a2463322/site_utils/test_push.py [modify] https://crrev.com/84a834fa96d1ea94ce132995905a8ad3a2463322/site_utils/test_push_common.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/51f41d87efec49fb3a369c6b0e9559775d0821eb commit 51f41d87efec49fb3a369c6b0e9559775d0821eb Author: Xixuan Wu <xixuan@chromium.org> Date: Tue Aug 21 18:17:44 2018 autotest: Query TKO for results for skylab_test_push. BUG= chromium:871968 TEST=Unittest. Change-Id: Ia82b98f9fa66f2eabd5959f0af4452f02b0a678d Reviewed-on: https://chromium-review.googlesource.com/1172732 Reviewed-by: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Commit-Queue: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> [modify] https://crrev.com/51f41d87efec49fb3a369c6b0e9559775d0821eb/site_utils/test_push_common.py [add] https://crrev.com/51f41d87efec49fb3a369c6b0e9559775d0821eb/venv/skylab_staging/test_push_unittest.py [modify] https://crrev.com/51f41d87efec49fb3a369c6b0e9559775d0821eb/venv/skylab_staging/swarming.py [add] https://crrev.com/51f41d87efec49fb3a369c6b0e9559775d0821eb/bin/test_skylab_staging [modify] https://crrev.com/51f41d87efec49fb3a369c6b0e9559775d0821eb/venv/skylab_staging/test_push.py [add] https://crrev.com/51f41d87efec49fb3a369c6b0e9559775d0821eb/venv/skylab_staging/conftest.py
Comment 1 by pprabhu@chromium.org
, Aug 7