New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871964 link

Starred by 1 user
Status: Fixed
Owner:
█ akaba@chromium.org
Last visit > 30 days ago
Closed: Aug 10
Cc:
samans@chromium.org
█ fsam...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GetLatestInFlightSurface should consider non-temporary references now.

Project Member Reported by akaba@chromium.org, Aug 7 
Since fallback is no longer mandatory, we can reference any surface between the fallback and primary thus we need GetLatestInFlightSurface to consider those surfaces while computing its result.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6647ad0cfab0a2bd286447d67e5e0d18c7e6727

commit e6647ad0cfab0a2bd286447d67e5e0d18c7e6727
Author: akaba <akaba@google.com>
Date: Fri Aug 10 02:16:16 2018

GetLatestInFlightSurface consider non-temporary references

This CL updates SurfaceManager::GetLatestInFlightSurface to consider
presistent references while computing the latest surface.
In addition, it allow GetLatestInFlightSurface to return something other
than the fallback in case the FrameSinkIds of the range differ.

Bug:  871964 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9f0de1cbb6bbdd10a69f70305a499123b34d7912
Reviewed-on: https://chromium-review.googlesource.com/1166163
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582019}
[modify] https://crrev.com/e6647ad0cfab0a2bd286447d67e5e0d18c7e6727/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/e6647ad0cfab0a2bd286447d67e5e0d18c7e6727/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/e6647ad0cfab0a2bd286447d67e5e0d18c7e6727/components/viz/service/surfaces/surface_manager.h

Comment 2 by akaba@chromium.org, Aug 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment