Skip the new "jsshell" variant in WPT |
||
Issue descriptionRecently, upstream WPT introduced a new global scope to the .any.js auto-generated tests: jsshell. Upstream infra change: https://github.com/web-platform-tests/wpt/pull/10769 The first usage: https://github.com/web-platform-tests/wpt/pull/12334 These "jsshell" test variants are blocking the import because of basename collisions: 1. The test name for the default "window" scope of a `*.any.js` test is `*.any.html`; the test name for the new "jsshell" scope is `*.any.js`. 2. In web tests (LayoutTests) infra, there's a wide assumption that baselines are unique, which is apparently violated here. Lots of tools are broken by this. In fact, the suite can't even run to complete because of colliding output files (*). * https://ci.chromium.org/buildbot/tryserver.blink/linux-blink-rel/520 After consulting the #testing channel, this new "jsshell" variant is for running tests in thin JS shells (e.g. Spidermonkey). There's no need to run them in a browser as there won't be any difference from the default window scope. Therefore, the simple and fortunately the proper fix here is to skip the "jsshell" variant altogether.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d39359fb0f0c8c8ee456242cf4ec34d8f270364 commit 2d39359fb0f0c8c8ee456242cf4ec34d8f270364 Author: Robert Ma <robertma@chromium.org> Date: Wed Aug 08 13:23:55 2018 [blinkpy] Skip the "jsshell" test variant in WPT This CL skips all the testharness tests with the extra property "jsshell" set to true when parsing the WPT manifest. These tests are generated from .any.js files with the optional "jsshell" global scope. They are intended to run in a JavaScript shell; when running in a browser, they behave the same as the default variant (i.e. the window scope, .any.html). Besides, the generated test names for the jsshell variant have the same basenames as the default varaint (*.any.js and *.any.html respectively), which breaks our infra. Bug: 871950 Change-Id: I9f8e81251550399a5d6566b49998aa79209dcf34 Reviewed-on: https://chromium-review.googlesource.com/1166332 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#581544} [modify] https://crrev.com/2d39359fb0f0c8c8ee456242cf4ec34d8f270364/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py [modify] https://crrev.com/2d39359fb0f0c8c8ee456242cf4ec34d8f270364/third_party/blink/tools/blinkpy/w3c/wpt_manifest_unittest.py
,
Aug 8
|
||
►
Sign in to add a comment |
||
Comment 1 by robertma@chromium.org
, Aug 8