New issue
Advanced search Search tips

Issue 871948 link

Starred by 2 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Aug 11
Cc:
chiniforooshan@chromium.org
ccameron@chromium.org
toyoshim@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

35.9% regression in rendering.desktop at 579908:580031

Project Member Reported by chiniforooshan@chromium.org, Aug 7 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 7 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=871948

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ab900a71571141514f10ff7b44256daa72ff7df71fe65701dc632aeda5c06013


Bot(s) for this bug's original alert(s):

mac-10_13_laptop_high_end-perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 7

Cc: ccameron@chromium.org
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/15dda73fa40000

Mac GPU process instability: Remove extra glFlushes by ccameron@chromium.org
https://chromium.googlesource.com/chromium/src/+/025a414b4c350bd5c8216ebfe173114ffa5bb363
13.23 → 16.48 (+3.252)

Mac: Cache monitor ICC profiles in the GPU process by ccameron@chromium.org
https://chromium.googlesource.com/chromium/src/+/8768493d87dd889bdf13da5333dce0015e5164af
16.38 → 18.11 (+1.723)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947f2fb9755802f60dd3bbe871c852dd79f240b3

commit 947f2fb9755802f60dd3bbe871c852dd79f240b3
Author: Christopher Cameron <ccameron@chromium.org>
Date: Wed Aug 08 20:02:01 2018

Correctly set DisplayICCProfiles::needs_update_

Bug:  869570 ,  871948 
Change-Id: I92312b385c7e38610aa92ad2e25a1b2fa0f192ff
Reviewed-on: https://chromium-review.googlesource.com/1166205
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581673}
[modify] https://crrev.com/947f2fb9755802f60dd3bbe871c852dd79f240b3/ui/gfx/mac/display_icc_profiles.cc

Comment 5 by ccameron@chromium.org, Aug 11

Cc: toyoshim@chromium.org
 Issue 872151  has been merged into this issue.

Comment 6 by ccameron@chromium.org, Aug 11

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 13

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641c47d1a39dbec86c8d476a19abe312f5001df1

commit 641c47d1a39dbec86c8d476a19abe312f5001df1
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Aug 13 17:32:02 2018

Correctly set DisplayICCProfiles::needs_update_

TBR=ccameron@chromium.org

(cherry picked from commit 947f2fb9755802f60dd3bbe871c852dd79f240b3)

Bug:  869570 ,  871948 
Change-Id: I92312b385c7e38610aa92ad2e25a1b2fa0f192ff
Reviewed-on: https://chromium-review.googlesource.com/1166205
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581673}
Reviewed-on: https://chromium-review.googlesource.com/1173011
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#568}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/641c47d1a39dbec86c8d476a19abe312f5001df1/ui/gfx/mac/display_icc_profiles.cc
►

Sign in to add a comment