New issue
Advanced search Search tips

Issue 871940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Visual glitch when issuing several async await commands on the console

Reported by j.mart...@animalltag.com.br, Aug 7

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

Steps to reproduce the problem:
1. Open the DevTools console
2. Run "await new Promise(resolve => setTimeout(() => resolve("hello"), 2000))" several times while the previous ones haven't resolved yet

What is the expected behavior?

What went wrong?
There is a visual glitch where the number at the start of the line overlap with the input or output arrow

Did this work before? N/A 

Chrome version: 68.0.3440.84  Channel: stable
OS Version: 10.0
Flash Version:
 
chrome_2018-08-07_17-50-31.png
3.5 KB View Download
Labels: Needs-Triage-M68
Cc: viswa.karala@chromium.org
Labels: Triaged-ET Target-70 M-70 FoundIn-70 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version# 68.0.3440.84 and on latest chrome# 70.0.3515.0 using Ubuntu 14.04, Mac 10.12.6 and Windows-10. As this is seen from M62(the response for "await new Promise(resolve => setTimeout(() => resolve("hello"), 2000))" is seen in console) , hence considering this issue as Non-Regression and marking it as Untriaged.

Thanks!
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96d3f1ad998aff72e39ecf86982df0c9309b485e

commit 96d3f1ad998aff72e39ecf86982df0c9309b485e
Author: Erik Luo <luoe@chromium.org>
Date: Tue Aug 14 17:52:38 2018

DevTools: fix repeat bubble overlap for commands, results

Console Commands and Results no longer show a repeat count bubble.
It was possible to get consecutive Commands using expressions
starting with 'await', which collapsed when they should not.

Screenshot: https://imgur.com/a/8iOkL9p

Bug:  871940 
Change-Id: I1dc2306d13c1511daa92fcd678520f3e8706e853
Reviewed-on: https://chromium-review.googlesource.com/1173265
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582968}
[modify] https://crrev.com/96d3f1ad998aff72e39ecf86982df0c9309b485e/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-repeat-count-expected.txt
[modify] https://crrev.com/96d3f1ad998aff72e39ecf86982df0c9309b485e/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-repeat-count.js
[modify] https://crrev.com/96d3f1ad998aff72e39ecf86982df0c9309b485e/third_party/blink/renderer/devtools/front_end/console/ConsoleView.js

Status: Fixed (was: Assigned)
Thanks for the report, and repro case.
No problem! Thank you and all the Chromium developers for all the good work and dedication.

Sign in to add a comment