New issue
Advanced search Search tips

Issue 871912 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-VR
Proj-XR-AR
Proj-XR

Blocked on:
issue 871908
Blocking:
issue 862707
issue 863068



Sign in to add a comment

AR DFM: Use string reference for title

Project Member Reported by tiborg@chromium.org, Aug 7 
Use an @string/ar_module_name reference for the AR DFM's dist:title attribute instead of hard coding it. To make the possible we will likely need build system changes. The @string/ar_module_name must be included in the base module but at the same time it needs to be referenced by the AR DFM's manifest. See  issue 871908  for enabling such sharing.

Comment 1 by tiborg@chromium.org, Aug 7

Labels: -Target-70 Target-71
Bumping to M71 as discussed.

Comment 2 by tiborg@chromium.org, Aug 24

Blocking: 863068

Comment 3 by tiborg@chromium.org, Aug 24

Owner: tiborg@chromium.org
Status: Started (was: Available)

Comment 4 by btebbs@chromium.org, Sep 4

Labels: AR-DFM
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c

commit 4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Sep 06 21:01:04 2018

[android:build] Allow resource reference from feature to base module

Bug:  871908 ,  871912 ,  875059 
Change-Id: I2a071d9a2d9b6cdf449d69e42e5bec8fe68f7884
Reviewed-on: https://chromium-review.googlesource.com/1204601
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589296}
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/compile_resources.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/prepare_resources.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/util/resource_utils.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/config/android/internal_rules.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/config/android/rules.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/BUILD.gn
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/ar/AndroidManifest.xml
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/ar/ar_module_tmpl.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/vr/AndroidManifest.xml
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/vr/vr_module_tmpl.gni

Comment 6 by tiborg@chromium.org, Sep 6

Status: Fixed (was: Started)
►

Sign in to add a comment