Issue metadata
Sign in to add a comment
|
InfoBarsTest.TestInfoBarsCloseOnNewTheme flaky on win10 |
||||||||||||||||||||||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64 InfoBarsTest.TestInfoBarsCloseOnNewTheme is very flaky. [ RUN ] InfoBarsTest.TestInfoBarsCloseOnNewTheme [6012:4704:0807/121631.762:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [6012:4716:0807/121631.778:WARNING:chrome_browser_main_win.cc(641)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=InfoBarsTest.TestInfoBarsCloseOnNewTheme --single_process --test-launcher-bot-mode --test-launcher-output="C:\b\s\w\itusvnso\scoped_dir1884_6237\results1884_7867\test_results.xml" --test-launcher-summary-output="C:\b\s\w\iocdkwfk\output.json" --user-data-dir="C:\b\s\w\itusvnso\scoped_dir1884_6237\d1884_25416" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2,WebRTC-H264WithOpenH264FFmpeg --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release_x64\gen" --restore-last-session about:blank [6012:4820:0807/121633.089:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico [756:2268:0807/121633.918:ERROR:webthread_impl_for_utility_thread.cc(19)] NOT IMPLEMENTED [3716:752:0807/121635.079:ERROR:webthread_impl_for_utility_thread.cc(19)] NOT IMPLEMENTED [6452:7852:0807/121636.434:ERROR:webthread_impl_for_utility_thread.cc(19)] NOT IMPLEMENTED [4088:2984:0807/121637.278:ERROR:webthread_impl_for_utility_thread.cc(19)] NOT IMPLEMENTED Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: views::NonClientFrameView::ShouldPaintAsActive [0x00007FF7D6EBFACE+14] BrowserNonClientFrameView::GetFrameColor [0x00007FF7D76A2BFD+13] TabStrip::ShouldDrawStrokes [0x00007FF7D85050E5+37] TabStrip::GetStrokeThickness [0x00007FF7D8506310+16] Tab::GetStrokeThickness [0x00007FF7D853622F+63] Tab::GetHitTestMask [0x00007FF7D8535A12+114] views::MaskedTargeterDelegate::DoesIntersectRect [0x00007FF7D853A02D+77] views::View::HitTestPoint [0x00007FF7D6EB5676+118] views::View::GetTooltipHandlerForPoint [0x00007FF7D6EB5527+39] views::View::GetTooltipHandlerForPoint [0x00007FF7D6EB5594+148] TabStrip::GetTooltipHandlerForPoint [0x00007FF7D850729C+236] views::View::GetTooltipHandlerForPoint [0x00007FF7D6EB5594+148] views::View::GetTooltipHandlerForPoint [0x00007FF7D6EB5594+148] views::View::GetTooltipHandlerForPoint [0x00007FF7D6EB5594+148] views::NonClientView::GetTooltipHandlerForPoint [0x00007FF7D6EBF928+104] views::View::GetTooltipHandlerForPoint [0x00007FF7D6EB5594+148] views::TooltipManagerAura::UpdateTooltip [0x00007FF7D7E7BF1E+158] views::View::DoRemoveChildView [0x00007FF7D6EB1F88+376] views::View::RemoveChildView [0x00007FF7D6EB18BD+29] views::NonClientView::SetFrameView [0x00007FF7D6EBF307+39] views::NonClientView::UpdateFrame [0x00007FF7D6EBF419+41] views::HWNDMessageHandler::PerformDwmTransition [0x00007FF7D8D64C80+48] views::DesktopWindowTreeHostWin::FrameTypeChanged [0x00007FF7D7E7DC44+20] BrowserDesktopWindowTreeHostWin::FrameTypeChanged [0x00007FF7DA0E268D+13] views::DesktopNativeWidgetAura::FrameTypeChanged [0x00007FF7D6EC21B5+21] content::NotificationServiceImpl::Notify [0x00007FF7D5BF9F60+1056] ThemeService::NotifyThemeChanged [0x00007FF7D6CD85C5+69] ThemeService::OnThemeBuiltFromExtension [0x00007FF7D6CD8C09+473] base::internal::FunctorTraits<void (__cdecl ThemeService::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const & __ptr64,scoped_refptr<BrowserThemePack>,bool) __ptr64,void>::Invoke<void (__cdecl ThemeService::*)(std::basic_string< [0x00007FF7D6CD9A3A+106] base::internal::Invoker<base::internal::BindState<void (__cdecl ThemeService::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const & __ptr64,scoped_refptr<BrowserThemePack>,bool) __ptr64,base::WeakPtr<ThemeService>,std::basic_stri [0x00007FF7D6CD992C+92] base::CancelableTaskTracker::Untrack [0x00007FF7D6B3B508+136] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(base::CancellationFlag const * __ptr64,base::OnceCallback<void __cdecl(void)>,base::OnceCallback<void __cdecl(void)>),base::internal::OwnedWrapper<base::CancellationFlag>,base::OnceCallback [0x00007FF7D6B3BDB4+68] base::internal::PostTaskAndReplyImpl::PostTaskAndReply [0x00007FF7D7AD772B+779] base::internal::PostTaskAndReplyImpl::PostTaskAndReply [0x00007FF7D7AD77E4+964] base::debug::TaskAnnotator::RunTask [0x00007FF7D7AC563C+300] base::MessageLoop::RunTask [0x00007FF7D6B03717+583] base::MessageLoop::DoWork [0x00007FF7D6B03C55+389] base::MessagePumpForUI::DoRunLoop [0x00007FF7D6B04EE9+169] base::MessagePumpWin::Run [0x00007FF7D6B04A7E+78] base::RunLoop::Run [0x00007FF7D6B25EA1+49] InfoBarsTest_TestInfoBarsCloseOnNewTheme_Test::RunTestOnMainThread [0x00007FF7D4295F89+921] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF7D6D3081B+459] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF7D7AF93E4+4772] ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF7D7AF802E+174] content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF7D5A0A1B5+85] content::StartupTaskRunner::RunAllTasksNow [0x00007FF7D5D32B4B+43] content::BrowserMainLoop::CreateStartupTasks [0x00007FF7D5A08AA8+616] content::BrowserMainRunnerImpl::Initialize [0x00007FF7D5A0C85E+126] content::BrowserMain [0x00007FF7D5A06A10+176] content::RunBrowserProcessMain [0x00007FF7D6A991CF+111] content::ContentMainRunnerImpl::Run [0x00007FF7D6A99AB3+483] service_manager::Main [0x00007FF7D7264E5E+782] content::ContentMain [0x00007FF7D6A99101+65] content::BrowserTestBase::SetUp [0x00007FF7D6D30539+1785] InProcessBrowserTest::SetUp [0x00007FF7D6B9D92C+556] testing::Test::Run [0x00007FF7D4FD7DA0+112] testing::TestInfo::Run [0x00007FF7D4FD873E+222] testing::TestCase::Run [0x00007FF7D4FD8CA2+258] testing::internal::UnitTestImpl::RunAllTests [0x00007FF7D4FDFDBE+638] testing::UnitTest::Run [0x00007FF7D4FDFA85+165] base::TestSuite::Run [0x00007FF7D6BB0736+118] ChromeTestSuiteRunner::RunTestSuite [0x00007FF7DA83D2B0+48]
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e462ebf8601301ce23010187655efa19c31f0553 commit e462ebf8601301ce23010187655efa19c31f0553 Author: Avi Drissman <avi@chromium.org> Date: Tue Aug 07 19:57:17 2018 Mark test as flaky. BUG= 871910 TBR=pkasting@chromium.org NOTRY=true Change-Id: I4c1100d7b95e654edeaa9b416c2cf9b0f6759339 Reviewed-on: https://chromium-review.googlesource.com/1165829 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581317} [modify] https://crrev.com/e462ebf8601301ce23010187655efa19c31f0553/chrome/browser/infobars/infobars_browsertest.cc
,
Aug 7
,
Aug 7
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39a62a9108120339bc58dd532eeb3517a450d741 commit 39a62a9108120339bc58dd532eeb3517a450d741 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Aug 08 05:03:07 2018 Let the BrowserNonClientFrameView decide whether to draw strokes This CL: * Uses the active frame color for deciding when to draw a stroke around the active tab * Prevents strokes from being draw on Aero glass themes * (Hopefully) Fixes a crash and flaky test BUG= 853841 ,871739, 871883 , 871910 R=pkasting Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c Reviewed-on: https://chromium-review.googlesource.com/1166546 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581477} [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/infobars/infobars_browsertest.cc [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/browser_non_client_frame_view.h [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip_controller.h
,
Aug 8
Test was reenabled and flakiness seems to be fixed: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64?limit=200
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcee3ef4289ecb833550c694d15bf535cb334704 commit fcee3ef4289ecb833550c694d15bf535cb334704 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Aug 14 19:10:10 2018 [Merge to M69] Let the BrowserNonClientFrameView decide whether to draw strokes > This CL: > > * Uses the active frame color for deciding when to draw a stroke around the > active tab > * Prevents strokes from being draw on Aero glass themes > * (Hopefully) Fixes a crash and flaky test > > BUG= 853841 ,871739, 871883 , 871910 > R=pkasting > > Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c > Reviewed-on: https://chromium-review.googlesource.com/1166546 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581477} BUG= 853841 ,871739, 871883 , 871910 TBR=pkasting NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I5a301e513742eb37dbf89a98fd694475a789a6e5 Reviewed-on: https://chromium-review.googlesource.com/1174991 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#622} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/browser_non_client_frame_view.h [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/glass_browser_frame_view.h [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip_controller.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Aug 7Owner: thomasanderson@chromium.org