New issue
Advanced search Search tips

Issue 871908 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Sep 6
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 871912
issue 875059



Sign in to add a comment

DFMs: support module title resource reference

Project Member Reported by tiborg@chromium.org, Aug 7 
A dynamic feature module's (DFM) title has to be set in its manifest's dist:module tag like so:

<dist:module dist:title="@string/my_module_name">
        ...
</dist:module>

In the example above, the string resource my_module_name must be included into the base module. The reason is that the string may be referenced before the DFM is installed, e.g. in an install confirmation dialog (see [1] for more details).

Find a way to share such a string resource between the base module and the DFM and allow the reference in the DFM's manifest.

[1] https://developer.android.com/guide/app-bundle/configure

Comment 1 by tiborg@chromium.org, Aug 7

Blocking: 871912

Comment 2 by tiborg@chromium.org, Aug 16

Blocking: 875059

Comment 3 by tiborg@chromium.org, Aug 21

Cc: agrieve@chromium.org

Comment 5 by tiborg@chromium.org, Aug 24

Owner: tiborg@chromium.org
Status: Started (was: Available)

Comment 6 by tiborg@chromium.org, Aug 24

Labels: -Target-70 Target-71
Targeting M-71 for bundles now.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c

commit 4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Sep 06 21:01:04 2018

[android:build] Allow resource reference from feature to base module

Bug:  871908 ,  871912 ,  875059 
Change-Id: I2a071d9a2d9b6cdf449d69e42e5bec8fe68f7884
Reviewed-on: https://chromium-review.googlesource.com/1204601
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589296}
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/compile_resources.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/prepare_resources.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/util/resource_utils.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/config/android/internal_rules.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/config/android/rules.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/BUILD.gn
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/ar/AndroidManifest.xml
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/ar/ar_module_tmpl.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/vr/AndroidManifest.xml
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/vr/vr_module_tmpl.gni

Comment 8 by tiborg@chromium.org, Sep 6

Status: Fixed (was: Started)
►

Sign in to add a comment