CHECK failure: !view || ContainsView(view) in focus_manager.cc |
|||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6672073498558464 Fuzzer: mojo_fuzzer Job Type: linux_asan_chrome_mojo Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: !view || ContainsView(view) in focus_manager.cc views::FocusManager::SetFocusedViewWithReason views::AccessiblePaneView::AcceleratorPressed Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=572427:572438 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6672073498558464 Additional requirements: Requires Gestures Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Aug 8
Predator and CL could not provide any possible suspects. Using the code search for the file, “focus_manager.cc” assigning to concern owner from GIT blame. Suspecting Commit# https://chromium.googlesource.com/chromium/src/+/aabb73a1a1a00cc3af265a643fc1aa883e1e63df afakhry@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes. Thank You.
,
Aug 8
This CHECK has been added by oshima@ here: https://chromium.googlesource.com/chromium/src/+/33c1e1d128713823e6fcc89deaaa92d7f832bdd5
,
Aug 8
The check is to detect misuse of the focus manager. Someone is trying to set focus on the view which does not belong to the widget that focus manager manages its focus.
,
Aug 8
Maybe this one? https://chromium-review.googlesource.com/c/chromium/src/+/525052 ViewStorage used to remove a view when its simply removed from the tree, but ViewTracker doesn't?
,
Aug 29
The patch Oshima mentions landed over a year ago. None-the-less, Oshima is certainly right about the change in behavior. I will fix AccessiblePaneView.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e62820eaa8b1d1aca1b0b4c50a53dccfc98574e1 commit e62820eaa8b1d1aca1b0b4c50a53dccfc98574e1 Author: Scott Violet <sky@chromium.org> Date: Fri Aug 31 15:13:51 2018 views: make AccessiblePaneView not restore focus in some cases Specifically if the View is still valid, but not in the same widget, then it should be ignored. BUG= 871899 TEST=covered by test Change-Id: I4d219df773c47113f4038a2163174d3041e684c5 Reviewed-on: https://chromium-review.googlesource.com/1195840 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#588026} [modify] https://crrev.com/e62820eaa8b1d1aca1b0b4c50a53dccfc98574e1/ui/views/accessible_pane_view.cc [modify] https://crrev.com/e62820eaa8b1d1aca1b0b4c50a53dccfc98574e1/ui/views/accessible_pane_view_unittest.cc
,
Aug 31
,
Sep 1
ClusterFuzz has detected this issue as fixed in range 588025:588026. Detailed report: https://clusterfuzz.com/testcase?key=6672073498558464 Fuzzer: mojo_fuzzer Job Type: linux_asan_chrome_mojo Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: !view || ContainsView(view) in focus_manager.cc views::FocusManager::SetFocusedViewWithReason views::AccessiblePaneView::AcceleratorPressed Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=572427:572438 Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=588025:588026 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6672073498558464 Additional requirements: Requires Gestures See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Sep 1
ClusterFuzz testcase 6672073498558464 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ClusterFuzz
, Aug 7Labels: Test-Predator-Auto-Components