New issue
Advanced search Search tips

Issue 871898 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task


Participants' hotlists:
Omnibox-Bugs-on-mpearson-Radar

Show other hotlists

Other hotlists containing this issue:
Hotlist-2


Sign in to add a comment

Make Sane Omnibox Provider Handling of Disabled Default Search Provider

Project Member Reported by mpear...@chromium.org, Aug 7

Issue description


The fix for (crashing)  bug 869384  introduces a new OmniboxClient function: IsDefaultSearchProviderEnabled().

We should use this in search_provider.cc, keyword_provider.cc, and related places.
https://cs.chromium.org/search/?q=GetDefaultSearchProvider+file:omnibox&sq=package:chromium&type=cs

Currently, the code sometimes uses null checks and sometimes doesn't bother.

Notably, I wouldn't be surprised if we still have edge case crashes in here.

We also apparently implicitly have some logic that's wrong; it assumes that if the user has a default provider, it's okay to provide suggestions even if the provider is disabled by policy.  I believe the "disabled by policy" flag is independent of whether the user actually has or doesn't have a default provider set.  (Obviously, it should be used if it's disabled...)

 
Cc: nicolaso@chromium.org

Sign in to add a comment