New issue
Advanced search Search tips

Issue 871883 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Aug 8
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 853841



Sign in to add a comment

[MdRefresh] Dark border appears around tabs and top Toolbar when window with Default Theme is in the background

Project Member Reported by meh...@chromium.org, Aug 7 
Chrome Version: Canary 70.0.3515.0
OS: macOS 10.13.6, but probably OS=All

What steps will reproduce the problem?
(1) Open a window with Default Theme (Normal or Incognito)
(2) Bring it in the background

What is the expected result?
No border for a clean appearing of the window.


What happens instead?
Tabs and top Toolbar receive a dark border.

This doesn't looks so nice :(

Maybe this shouldn't happen for the default theme?

Not sure if this is intended.

Thanks for listening,
Mehmet
Background_border.mov
716 KB View Download

Comment 1 by pkasting@chromium.org, Aug 7

Blocking: 853841
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Yeah, we're working on a fix.

Comment 2 by meh...@chromium.org, Aug 7 

Thanks for your feedback. Maybe interesting, if the border will be used for other themes: It looks like the border around the tabs is „stealing“ 1px of the height of the tabs, whereas the border top of the toolbar does not steal 1px. So it looks like the tabs are shrinking by 1 px and the Toolbar not. I hope it is clear what I mean :) I think it is noticeable in the screencast from my comment 0.

Comment 3 by pkasting@chromium.org, Aug 7 

Your analysis is correct.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a62a9108120339bc58dd532eeb3517a450d741

commit 39a62a9108120339bc58dd532eeb3517a450d741
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 08 05:03:07 2018

Let the BrowserNonClientFrameView decide whether to draw strokes

This CL:

* Uses the active frame color for deciding when to draw a stroke around the
  active tab
* Prevents strokes from being draw on Aero glass themes
* (Hopefully) Fixes a crash and flaky test

BUG= 853841 ,871739, 871883 , 871910 
R=pkasting

Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c
Reviewed-on: https://chromium-review.googlesource.com/1166546
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581477}
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip_controller.h

Comment 5 by thomasanderson@chromium.org, Aug 8

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 14

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcee3ef4289ecb833550c694d15bf535cb334704

commit fcee3ef4289ecb833550c694d15bf535cb334704
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 14 19:10:10 2018

[Merge to M69] Let the BrowserNonClientFrameView decide whether to draw strokes

>  This CL:
>
>  * Uses the active frame color for deciding when to draw a stroke around the
>    active tab
>  * Prevents strokes from being draw on Aero glass themes
>  * (Hopefully) Fixes a crash and flaky test
>
>  BUG= 853841 ,871739, 871883 , 871910 
>  R=pkasting
>
>  Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c
>  Reviewed-on: https://chromium-review.googlesource.com/1166546
>  Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
>  Reviewed-by: Peter Kasting <pkasting@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#581477}

BUG= 853841 ,871739, 871883 , 871910 
TBR=pkasting
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I5a301e513742eb37dbf89a98fd694475a789a6e5
Reviewed-on: https://chromium-review.googlesource.com/1174991
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#622}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip_controller.h

Comment 7 by swarnasree.mukkala@chromium.org, Aug 16

Labels: TE-Verified-M69 TE-Verified-69.0.3497.42
Able to reproduce the issue on Mac 10.13.1 on build without fix #70.0.3515.0.

Verified the fix on Mac 10.13.1, as per comment#0 on chrome version #69.0.3497.42.
Attaching screen cast for reference.
Observed that no border around tabs  and top toolbar in default theme window.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!
871883.mp4
749 KB View Download
►

Sign in to add a comment