New issue
Advanced search Search tips

Issue 871871 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Tricium spellchecker: Don't warn on usernames

Project Member Reported by qyears...@chromium.org, Aug 7

Issue description

We never want to warn on usernames.

 - Usernames appear in certain places, such as in OWNERS files
 - Usernames appear in: TODO(name) and name@<domain>.

Usernames are open-ended and many more will be added in the future.

Proposed changes:
 - Don't check OWNERS files
 - Don't check TODO(...) and ...@<domain>.
 
Cc: mar...@chromium.org
One thought about not checking OWNERS files --

Our current behavior is to check all of all files for which we don't know the extension. But, apart from OWNERS, there are potentially lots of types of files that would have false positives -- and I suspect files for which we don't know the type seem more likely to have false positives. For example, e.g. .json, .patch, .expected, .template, .pem, ...

We currently have a whitelist of "text" file types to check all of, so I think unknown file types should generally not be checked.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c8b4e6018a806aea5493b9da3e501fcec3f61807

commit c8b4e6018a806aea5493b9da3e501fcec3f61807
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Aug 09 23:32:19 2018

[tricium spellchecker] Skip checking files with unknown types

This CL proposes to change SpellChecker to be more conservative,
and not check any files with unknown types. This means that
.txt and .md files would still be checked; and all known source
types with comment patterns would be checked; but files named
"OWNERS", "foo", "something.patch", "x.expected" etc. would
not be checked.

Bug:  871871 
Change-Id: Idcc29dd62f2cf2f9bedac5a56818095f06e69aae
Reviewed-on: https://chromium-review.googlesource.com/1169909
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/c8b4e6018a806aea5493b9da3e501fcec3f61807/go/src/infra/tricium/functions/spellchecker/spellchecker_test.go
[modify] https://crrev.com/c8b4e6018a806aea5493b9da3e501fcec3f61807/go/src/infra/tricium/functions/spellchecker/spellchecker.go

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ee824637cdeb1b735657675cfa0c8cba83ae9f9e

commit ee824637cdeb1b735657675cfa0c8cba83ae9f9e
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Aug 13 20:54:13 2018

[tricium spellchecker] Don't flag words in TODO or email addresses

Bug:  871871 
Change-Id: Id5166d2f0694565f90e8b7ebdbd86e8986184ce3
Reviewed-on: https://chromium-review.googlesource.com/1173164
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/ee824637cdeb1b735657675cfa0c8cba83ae9f9e/go/src/infra/tricium/functions/spellchecker/spellchecker_test.go
[modify] https://crrev.com/ee824637cdeb1b735657675cfa0c8cba83ae9f9e/go/src/infra/tricium/functions/spellchecker/spellchecker.go

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/19a5263ba551e2176c937d6c911c3fa42ab4ccf5

commit 19a5263ba551e2176c937d6c911c3fa42ab4ccf5
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Aug 14 23:19:16 2018

[tricium spellchecker] Add some words to not flag

Bug:  874211 ,  871871 
Change-Id: I4767f467037dde9e36b97d81ae2ac7e990e7abd1
Reviewed-on: https://chromium-review.googlesource.com/1175221
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/19a5263ba551e2176c937d6c911c3fa42ab4ccf5/go/src/infra/tricium/functions/spellchecker/spellchecker.go

Sign in to add a comment