New issue
Advanced search Search tips

Issue 871848 link

Starred by 28 users

Issue metadata

Status: Fixed
Merged: issue 870404
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

PDF DISPLAYS AS BLANK PAGE

Reported by e...@murj.com, Aug 7

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

Example URL:
HIPAA PROMLEM. SORRY

Steps to reproduce the problem:
1. OPEN A ST. JUDE MEDICAL DEVICE EPISODE REPORT PDF IN THE CHROMIUM PDF RENDERER. 
2. 
3. 

What is the expected behavior?
THE EXPECTED BEHAVIOR IS TO BE ABLE TO VIEW THE ELCTROGRAM WAVE FORM.

What went wrong?
ALL THAT IS DISPLAYED IS A BLANK PAGE BUT THE PAGE COUNT IS CORRECT. THERE IS JUST NOTHING ON THE PAGE. 

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes 67.X.XXXX

Does this work in other browsers? Yes

Chrome version: 68.0.3440.84  Channel: stable
OS Version: OS X 10.13.6
Flash Version: 

WE CAN SEE THE EGM (ELECTROGRAM) ON FIREFOX, IE, AND SAFARI.
THE PROBLEM IS HOW THE CHROMIUM PDF RENDERER IS HANDLING THE SPECIFIC PDF FROM ST. JUDE AND JUST THEIR EGM'S.
 
Labels: Needs-Triage-M68 Needs-Bisect
Components: -Blink Internals>Plugins>PDF
Labels: -Needs-Bisect Triaged-ET
Mergedinto: 870404
Status: Duplicate (was: Unconfirmed)
The issue looks similar to issue id: 870404. Hence, merging into the issue id: 870404.

Thanks...!!
It is not this issue. Sorry. I just tried it and moving from one tab to
another does not allow the pdf to be displayed.

Cheers,

Eric

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
Here is a screen shot of a pdf that I tried to open.
Screen Shot 2018-08-07 at 10.37.59 PM.png
43.5 KB View Download
Status: Unconfirmed (was: Duplicate)
Do you have a sample PDF that demonstrates this problem that you can share?
Unfortunately because of the U.S. food and drug administrations hipaa laws
I can not send one because all of the ones I have, have patient data in
them. They comes from st. Jude devices  though. St. Jude medical devices
will most likely have sample PDFs for this purpose.
Can you ask St. Jude for a sample PDF that doesn't contain patient data, or has fake data? It's hard to treat a patient that cannot be seen.
I am working on it. I should have one for you shortly.

Thank you so much btw.

Cheers,

Eric Johnson

831.334.9133

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
Ok I have a pdf for you but I also have something better for you.

I actually have the demo site login and can navigate you to the pdf that is
blank.

The pdf is attached and here are instructions on how to get to the pdf in
question.

go to:
https://demo.merlin.net/group/merlin-ep_b/transmission-details?websiteNotificationId=50000129&reportType=EPD&reportFamilyType=EPSD&&sessiondtm=1343649045000

Then click on this 07-30-2012 04:50 AM

This will bring up the pdf display failure.

Cheers,

Eric Johnson
831.334.9133

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
Ok I have a pdf for you but I also have something better for you.

I actually have the demo site login and can navigate you to the pdf that is
blank.

The pdf is attached and here are instructions on how to get to the pdf in
question.

User Name for site below: demo_us1
Password: merlin80

go to: https://demo.merlin.net/group/merlin-ep_b/transmission-
details?websiteNotificationId=50000129&reportType=EPD&
reportFamilyType=EPSD&&sessiondtm=1343649045000

Then click on this 07-30-2012 04:50 AM

This will bring up the pdf display failure.

Cheers,

Eric Johnson
831.334.9133


Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
Thanks for setting up the demo website. I tried it out and the PDF displays just fine. I downloaded the PDF (TransmissionReportServlet_B.pdf) and opened it in a new window and that worked too. The heading on the PDF is "FastPath Summary". Does this sound like the right PDF?

Can you double check with a friend or colleague, and see if they can reproduce this issue on their computer?
Fast path is the wrong file you have to open episodes and egms. Did you
follow the link and open the dated hyper link on the page that I sent you
too?

Eric
Please see attachment.

Eric
Labels: OS-Chrome OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Email attachments don't work, unfortunately.

I opened the right link this time. The 3 page PDF titled "Freeze Capture" is indeed blank.
That's the issue we've been seeing. Not sure what's going on. Thank you for
all your help.
Labels: -Type-Bug Type-Bug-Regression
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
It used to work. Very likely my fault.
Ha!!! no way. It was probably st. judes fault

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
I don't mean to bug you but I would totally love to hear about what
happened and why the pdf is failing to render when you have it figured out.

What I am hoping doesn't happen is that St. Jude try's to come up with a
fix before you guys do and then they create another problem......

Thank you again for helping me out with this.

Cheers,

Eric Johnson
831.334.9133

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
Status: Started (was: Assigned)
No, it's not St. Jude's fault. In the affected PDFs, every page is really just one big image. The image format has many fields to describe its characteristics. e.g. "I have this many pixels" Images can be malformed and lie about its characteristics, which can confuse software that reads those images in bad ways. So I tried to check for one such case, but made the check too strict. Now valid images are being rejected instead of being rendered.
Thank you so much for the info. Can let me know a rough estimate in time
for a fix?

Cheers,

Eric
Labels: -Needs-Triage-M68
Probably about ~2 days for Chrome Canary channel, and about a month for Stable channel.
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/b0fc6e958634d919349e2a7611dd99f121e41d7d

commit b0fc6e958634d919349e2a7611dd99f121e41d7d
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Aug 10 16:47:57 2018

Fix a JBIG2 decoding regression.

When trying to sanity check SBNUMINSTANCES for JBIG2 text regions for
 https://crbug.com/837192 , the check did not take data encoding into
account. Fix this by assuming there is a potential for 16:1 compression
in the lossless encoding.

BUG= chromium:871848 

Change-Id: I991dacff9fbefa4e302f5ce92a355902ef94308a
Reviewed-on: https://pdfium-review.googlesource.com/39790
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/b0fc6e958634d919349e2a7611dd99f121e41d7d/core/fxcodec/jbig2/JBig2_Context.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afe7c7414699ca66dbf49b162ab2c49083889a4d

commit afe7c7414699ca66dbf49b162ab2c49083889a4d
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 10 23:29:27 2018

Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)

https://pdfium.googlesource.com/pdfium.git/+log/e1a7e8589a8c..f36a4644b828


git log e1a7e8589a8c..f36a4644b828 --date=short --no-merges --format='%ad %ae %s'
2018-08-10 rharrison@chromium.org Remove direct calls to time
2018-08-10 rharrison@chromium.org Add proxy for syscall time
2018-08-10 tsepez@chromium.org Remove |typedef struct| in favor of just |struct|.
2018-08-10 tsepez@chromium.org Consolidate const_casts<> in FXFT_Get_Name_Index()
2018-08-10 thestig@chromium.org Make CFX_ImageTransformer::CalcData's bitmap non-const.
2018-08-10 thestig@chromium.org Fix a JBIG2 decoding regression.
2018-08-10 thestig@chromium.org Remove deprecated flags from fpdf_progressive.h.


Created with:
  gclient setdep -r src/third_party/pdfium@f36a4644b828

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:871848 
TBR=dsinclair@chromium.org

Change-Id: I22721ff61265f49fddd6ffc647ef37cc2f70bc0c
Reviewed-on: https://chromium-review.googlesource.com/1171442
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#582382}
[modify] https://crrev.com/afe7c7414699ca66dbf49b162ab2c49083889a4d/DEPS

If you install Chrome Canary, you should be able to verify this issue has been fixed there.
Labels: Merge-Request-69 RegressedIn-68 Target-69
Verified this is fixed in today's canary.
Project Member

Comment 26 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This is regressed in M68,how critical and safe is the change to merge to M69?
The fix for this bug only affects PDFs and won't cause any regressions or stability issues.
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #25 and #28. Please merge ASAP. Thank you.
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 13

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/139f7fbf60c4031760e15d28546d9d221c0fdc65

commit 139f7fbf60c4031760e15d28546d9d221c0fdc65
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Aug 13 23:48:51 2018

M69: Fix a JBIG2 decoding regression.

When trying to sanity check SBNUMINSTANCES for JBIG2 text regions for
 https://crbug.com/837192 , the check did not take data encoding into
account. Fix this by assuming there is a potential for 16:1 compression
in the lossless encoding.

TBR=rharrison@chromium.org
BUG= chromium:871848 

Change-Id: I991dacff9fbefa4e302f5ce92a355902ef94308a
Reviewed-on: https://pdfium-review.googlesource.com/39790
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
(cherry picked from commit b0fc6e958634d919349e2a7611dd99f121e41d7d)
Reviewed-on: https://pdfium-review.googlesource.com/39993
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/139f7fbf60c4031760e15d28546d9d221c0fdc65/core/fxcodec/jbig2/JBig2_Context.cpp

Status: Fixed (was: Started)
This should be fixed in M69 (current Beta channel) within a week or so.
Labels: Hotlist-ConOps
Thank you so much for the info. Do you know if it has been fixed in M69
(current Beta Channel) yet? Thank you again.

Cheers,

Eric

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <(831)334-9133>
The current Beta release is 69.0.3497.42 and this issue is fixed there.
I wanted to follow up and see when, roughly, the fix would be applied to
the stable channel?
Cheers,

Eric Johnson

Customer Success Manager  |  Murj Inc <https://www.murj.com/>
c: 831.334.9133 <javascript:void(0);>
According to https://www.chromestatus.com/features/schedule M69 is scheduled to go stable Sept 4.
Very confusing, is there a fix yes or no.  If yes how do you fix the issue?

Walter 

Walter read the rest of the thread. The fix is already done in beta! That means that in the stable release its fixed but not until the stable channel goes public on the 4th of Sept.

Eric
Just wanted to follow up and see if 69 will be released today? 
I believe the automatic update to M69 start today. Updates usually happens in a gradual fashion.
It is fixed!!!!!! Thank you so much for all your help!!

Sign in to add a comment