Mobmonitor on wukong show message "Failed DiskDevices" check |
||||
Issue descriptionM68 moblab - on a wukong device - fails the DiskDevices check.
,
Aug 9
This is present unless you disable read only rootfs with `sudo /usr/share/vboot/bin/make_dev_ssd.sh --remove_rootfs_verification --partitions 2 ` (which unfortunately makes it hard to debug :( ) The output of `lsblk --pairs --bytes --output NAME,RM,TYPE,SIZE` changes after disabling rootfs read only. Before, some lines have RM="". After, all lines have RM="1" or RM="2". The regex misses lines with RM="" and doesn't parse enough values to pass into the BlockDevice constructor, then dies.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/439a5487f9070864a879ff553282e7fad912679a commit 439a5487f9070864a879ff553282e7fad912679a Author: Matt Mallett <mattmallett@chromium.org> Date: Fri Aug 10 08:44:26 2018 [moblab] Fix mobmonitor DiskCheck on wukong The DiskCheck mobmonitor check doesn't run on wukong. In some cases, lsblk returns an empty string for the removable field RM="". Make the regex more robust to find an empty string and treat it as a valid value. BUG= chromium:871833 TEST=osutils_unittest.py, systeminfo_unittest.py Change-Id: I759b27369e4cb0ebdd1f8d87a2f7a6524e73410e Reviewed-on: https://chromium-review.googlesource.com/1168599 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/439a5487f9070864a879ff553282e7fad912679a/src/mobmonitor/util/osutils.py
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/eb64d6ad27ea76d2b7b811de6df185c50bae0694 commit eb64d6ad27ea76d2b7b811de6df185c50bae0694 Author: Matt Mallett <mattmallett@chromium.org> Date: Fri Aug 10 17:12:43 2018 [moblab] Fix mobmonitor DiskCheck on wukong The DiskCheck mobmonitor check doesn't run on wukong. In some cases, lsblk returns an empty string for the removable field RM="". Make the regex more robust to find an empty string and treat it as a valid value. BUG= chromium:871833 TEST=osutils_unittest.py, systeminfo_unittest.py Change-Id: I759b27369e4cb0ebdd1f8d87a2f7a6524e73410e Reviewed-on: https://chromium-review.googlesource.com/1168599 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit 439a5487f9070864a879ff553282e7fad912679a) [modify] https://crrev.com/eb64d6ad27ea76d2b7b811de6df185c50bae0694/src/mobmonitor/util/osutils.py
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/84630ca758217e667332e156c12c73734f8e456b commit 84630ca758217e667332e156c12c73734f8e456b Author: Matt Mallett <mattmallett@chromium.org> Date: Fri Aug 10 17:13:20 2018 [moblab] Fix mobmonitor DiskCheck on wukong The DiskCheck mobmonitor check doesn't run on wukong. In some cases, lsblk returns an empty string for the removable field RM="". Make the regex more robust to find an empty string and treat it as a valid value. BUG= chromium:871833 TEST=osutils_unittest.py, systeminfo_unittest.py Change-Id: I759b27369e4cb0ebdd1f8d87a2f7a6524e73410e Reviewed-on: https://chromium-review.googlesource.com/1168599 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit 439a5487f9070864a879ff553282e7fad912679a) [modify] https://crrev.com/84630ca758217e667332e156c12c73734f8e456b/src/mobmonitor/util/osutils.py
,
Aug 17
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mattmallett@chromium.org
, Aug 8